ci: run tests and linting once

Author: scagood

.github/workflows/CI.yml

@@ -22,10 +22,9 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: 20.x
-      - name: Install Packages
-        run: npm install
-      - name: Lint
-        run: npm run -s lint
+      - run: npm install
+      - run: npm run -s lint
+      - run: npm run -s test:types
 
   test:
     name: Test
@@ -64,7 +63,6 @@ jobs:
       - name: Install Packages
         run: npm install
       - name: Install ESLint ${{ matrix.eslint }}
-        run: |
-          npm install --no-save --force eslint@${{ matrix.eslint }}
+        run: npm install --no-save --force eslint@${{ matrix.eslint }}
       - name: Test
-        run: npm run -s test
+        run: npm run -s test:tests

lib/util/get-configured-node-version.js

@@ -4,15 +4,14 @@
  */
 "use strict"
 
-const { Range } = require("semver") // eslint-disable-line no-unused-vars
 const getPackageJson = require("./get-package-json")
 const getSemverRange = require("./get-semver-range")
 
 /**
  * Gets `version` property from a given option object.
  *
  * @param {Record<string, string>|undefined} option - An option object to get.
- * @returns {Range|undefined} The `allowModules` value, or `null`.
+ * @returns {import("semver").Range|undefined} The `allowModules` value, or `null`.
  */
 function getVersionRange(option) {
     if (option?.version) {
@@ -25,7 +24,7 @@ function getVersionRange(option) {
 /**
  * Get the `engines.node` field of package.json.
  * @param {import('eslint').Rule.RuleContext} context The path to the current linting file.
- * @returns {Range|undefined} The range object of the `engines.node` field.
+ * @returns {import("semver").Range|undefined} The range object of the `engines.node` field.
  */
 function getEnginesNode(context) {
     const filename = context.filename ?? context.getFilename()
@@ -45,15 +44,15 @@ function getEnginesNode(context) {
  *
  * @param {import('eslint').Rule.RuleContext} context The version range text.
  * This will be used to look package.json up if `version` is not a valid version range.
- * @returns {Range} The configured version range.
+ * @returns {import("semver").Range} The configured version range.
  */
 module.exports = function getConfiguredNodeVersion(context) {
     return (
         getVersionRange(context.options?.[0]) ??
         getVersionRange(context.settings?.n) ??
         getVersionRange(context.settings?.node) ??
         getEnginesNode(context) ??
-        /** @type {Range} */ (getSemverRange(">=16.0.0"))
+        /** @type {import("semver").Range} */ (getSemverRange(">=16.0.0"))
     )
 }
 

package.json

@@ -67,11 +67,10 @@
         "prepack": "tsc --emitDeclarationOnly",
         "prepare": "husky",
         "preversion": "npm test",
-        "test": "run-p test:types test:lint test:tests",
-        "test:lint": "npm run -s lint",
+        "test": "run-p lint:* test:types test:lint test:tests",
+        "test:mocha": "_mocha  --reporter progress --timeout 4000",
         "test:tests": "npm run test:mocha \"tests/lib/**/*.js\"",
         "test:types": "tsc --noEmit --emitDeclarationOnly false",
-        "test:mocha": "_mocha  --reporter progress --timeout 4000",
         "update:eslint-docs": "eslint-doc-generator",
         "version": "npm run -s build && eslint lib/rules --fix && git add .",
         "watch": "npm run test:_mocha -- --watch --growl"