[mdns]: v1.10: Fix to keep TXT/SRV in answers to queries #959
Conversation
|
@tanyanquan PTAL, too |
components/mdns/mdns_send.c
Outdated
| send_flush, false)) { | ||
| return false; | ||
| } | ||
| } else if (is_any_instance_question) { |
There was a problem hiding this comment.
Maybe we can put this block first, followed by
else if (question->type == MDNS_TYPE_PTR || question->type == MDNS_TYPE_ANY)
for clarity
There was a problem hiding this comment.
How about using the original expression (question->type == MDNS_TYPE_ANY) && is_instance_question , just to follow consistency with other if conditions, and adding a comment in this if branch?
There was a problem hiding this comment.
Good point, have swapped these branches and removed the unnecessary is_any_instance_question.
thanks!
components/mdns/mdns_send.c
Outdated
| send_flush, false)) { | ||
| return false; | ||
| } | ||
| } else if (is_any_instance_question) { |
There was a problem hiding this comment.
How about using the original expression (question->type == MDNS_TYPE_ANY) && is_instance_question , just to follow consistency with other if conditions, and adding a comment in this if branch?
unlike discoveries, where they need to stay in additional section Quick fix of regression b7b8c5d Also adds a test to check the answer section for queries
david-cermak
force-pushed
the
fix/mdns_v1.10
branch
from
7424337 to
3441d8c
Compare
3 participants
unlike discoveries, where they need to stay in additional section
Quick fix of regression b7b8c5d