-
Notifications
You must be signed in to change notification settings - Fork 119
Building for ESP32-P4 using esp_hosted and esp_wifi_remote (IEC-388) #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@suda-morris PTAL.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables Wi-Fi provisioning support for ESP32-P4 using a two-chip solution with ESP-Hosted and esp_wifi_remote components. The ESP32-P4 connects to an ESP32-C6 co-processor via SDIO for Wi-Fi and Bluetooth functionality.
- Added ESP32-P4 configuration file with required settings for ESP-Hosted and Wi-Fi remote
- Updated component dependencies to include esp_wifi_remote and esp_hosted for ESP32-P4/H2 targets
- Added comprehensive documentation for ESP32-P4 setup and usage
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sdkconfig.defaults.esp32p4 | ESP32-P4 specific configuration enabling BT, Wi-Fi remote, and performance settings |
| main/idf_component.yml | Added conditional dependencies for esp_wifi_remote and esp_hosted components |
| README.md | Updated supported targets table and added ESP32-P4 documentation section |
| CHANGELOG.md | Added changelog entry documenting ESP32-P4 support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
network_provisioning/examples/wifi_prov/sdkconfig.defaults.esp32p4
Outdated
Show resolved
Hide resolved
network_provisioning/examples/wifi_prov/sdkconfig.defaults.esp32p4
Outdated
Show resolved
Hide resolved
e4d1398 to
c90f45b
Compare
| espressif/esp_wifi_remote: | ||
| version: ">=0.10" | ||
| rules: | ||
| - if: "target in [esp32p4, esp32h2]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we remove from H2 from the list? H2 can support thread provisioning in standalone manner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that H2 can be removed, as H2 is not mentioned in the supported targets list of README file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually H2 can use wifi-remote & hosted for wifi provisioning. So should we keep it or not, @mahavirj ?
I will update H2 in supported target accordingly..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mantriyogesh For H2, we recommend using network_provisioning/examples/thread_prov example. H2 is already listed a supported target here.
Actually H2 can use wifi-remote & hosted for wifi provisioning.
Is this for Thread Boarder router use-case? Does it use hosted approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree the H Series would be native wifi provisioning generally be used and is more intuitive.
But if H2 wants to do wifi based provisioning (technically be possible using two chip using esp-wifi-remote & esp-hosted duo).
| # Override some defaults so BT stack is enabled | ||
| # in this example | ||
|
|
||
| CONFIG_FREERTOS_HZ=1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we can remove this - not a mandatory requirement?
| espressif/esp_hosted: | ||
| version: "~2" | ||
| rules: | ||
| - if: "target in [esp32p4, esp32h2]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as earlier to remove H2
|
Please check #592 and see if we can add |
Checklist
urlfield definedChange description
Building the wifi provisiong for ESP32-P4 using esp_hosted and esp_wifi_remote component