Merge pull request #192 from rikkuness/clean-up-lint-warnings

Clean up some more of the lint warnings

Author: gfwilliams

core/flasher.js

@@ -362,7 +362,7 @@
       console.log("Downloaded "+binary.byteLength+" bytes");
       flashBinaryToDevice(binary, flashOffset, callback, statusCallback);
     });
-  };
+  }
 
 
   function resetDevice(callback) {
@@ -417,9 +417,7 @@
         }, 2000/*timeout*/);
       });
     });
-  };
-
-
+  }
 
   Espruino.Core.Flasher = {
     init : init,

core/flasherESP8266.js

@@ -13,7 +13,7 @@
 (function(){
 
   const BLOCK_SIZE = 0x400;
-  var uart;
+  // var uart;
   var uartLine = "";
   var packetHandler;
 
@@ -166,7 +166,7 @@ function unsetupEspruino(options) {
 function cmdSync(options) {
   console.log("Syncing...");
   return new Promise((resolve,reject)=>{
-    var success = false;
+    // var success = false;
     var interval;
     packetHandler = function(d) {
       if (d.cmd==8) {

core/modules.js

@@ -126,20 +126,20 @@
     console.log("loadModule("+fullModuleName+")");
 
     var urls = []; // Array of where to look for this module
-    var modName; // Simple name of the module
+    // var modName; // Simple name of the module
     if(Espruino.Core.Utils.isURL(fullModuleName)) {
-      modName = fullModuleName.substr(fullModuleName.lastIndexOf("/") + 1).split(".")[0];
+      // modName = fullModuleName.substr(fullModuleName.lastIndexOf("/") + 1).split(".")[0];
       urls = [ fullModuleName ];
     } else {
-      modName = fullModuleName;
+      // modName = fullModuleName;
       Espruino.Config.MODULE_URL.split("|").forEach(function (url) {
         url = url.trim();
         if (url.length!=0)
         Espruino.Config.MODULE_EXTENSIONS.split("|").forEach(function (extension) {
           urls.push(url + "/" + fullModuleName + extension);
         })
       });
-    };
+    }
 
     // Recursively go through all the urls
     (function download(urls) {
@@ -234,7 +234,7 @@
         callback(loadedModuleData.join("\n") + "\n" + code);
       });
     }
-  };
+  }
 
 
   Espruino.Core.Modules = {

core/serial_chrome_serial.js

@@ -30,7 +30,7 @@ Author: Gordon Williams ([email protected])
   }
 
   var connectionInfo;
-  var connectedPort; // unused?
+  // var connectedPort; // unused?
   var connectionDisconnectCallback;
   var connectionReadCallback;
 
@@ -65,7 +65,7 @@ Author: Gordon Williams ([email protected])
           openCallback(undefined);
         } else {
           connectionInfo = cInfo;
-          connectedPort = serialPort;
+          // connectedPort = serialPort;
           console.log(cInfo);
           openCallback(cInfo);
         }

core/serial_web_audio.js

@@ -218,7 +218,7 @@
         connectionReadCallback(arr.buffer);
       }, 10);
     }
-  };
+  }
 
   // ----------------------------------------------------------
 

core/terminal.js

@@ -335,7 +335,7 @@
       callback(data);
     });
 
-  };
+  }
 
   /* check for any terminal-inline-image and if they are still BMP
   then convert them to PNG using canvas */
@@ -430,7 +430,7 @@
       if (i in elements)
         elements[i].remove();
     // now write this to the screen
-    var t = [];
+    // var t = [];
     for (var y in termText) {
       var line = termText[y];
       if (y == termCursorY) {
@@ -483,7 +483,8 @@
       var pos = cursor[0].getBoundingClientRect();
       var terminalfocus = document.getElementById("terminalfocus");
       var x = Math.min(pos.left, terminal.offsetWidth);
-      var y = Math.min(pos.top-tPos.top, terminal.height-terminalfocus.offsetHeight);
+      // TODO: 'y' is already defined in outer scope, but this redeclaration doesn't appear to be used in this scope?
+      var y = Math.min(pos.top-tPos.top, terminal.height-terminalfocus.offsetHeight); 
       terminalfocus.style.left=x+"px";
       terminalfocus.style.top=(pos.top-tPos.top)+"px";
     }
@@ -495,8 +496,6 @@
     return str.substr(0,s+1);
   }
 
-
-
   var handleReceivedCharacter = function (/*char*/ch) {
     function isUTF8StartChar(ch) {
       return (ch>=0xC2) && (ch<=0xF4);
@@ -612,7 +611,7 @@
     var old = onInputData;
     onInputData = callback;
     return old;
-  };
+  }
 
   /// Called when data comes OUT of Espruino INTO the terminal
   function outputDataHandler(readData) {
@@ -632,7 +631,7 @@
         displayData = [];
         displayTimeout = null;
       }, 50);
-  };
+  }
 
   var receivedData = "";
   function searchData(bytes){
@@ -661,36 +660,36 @@
     });
     // Ensure that data from Espruino goes to this terminal
     Espruino.Core.Serial.startListening(Espruino.Core.Terminal.outputDataHandler);
-  };
+  }
 
   /// Get the current terminal line that we're on
   function getCurrentLine() {
     return termText.length-1;
-  };
+  }
 
   /// Set extra text to display before a certain terminal line
   function setExtraText(line, text) {
     if (termExtraText[line] != text) {
       termExtraText[line] = text;
       updateTerminal();
     }
-  };
+  }
 
   /// Clear all extra text that is to be displayed
   function clearExtraText() {
     termExtraText = {};
     updateTerminal();
-  };
+  }
 
   /// Does the terminal have focus?
   function hasFocus() {
     return document.querySelector("#terminal").classList.contains("focus");
-  };
+  }
 
   /// Give the terminal focus
   function focus() {
     document.getElementById("terminalfocus").focus();
-  };
+  }
 
   // Is the terminal actually visible, or is it so small it can't be seen?
   function isVisible() {
@@ -713,15 +712,15 @@
     while (line < termText.length && termText[line].substr(0,1)==":")
       text += "\n"+termText[line++].substr(1);
     return { line : startLine, text : text };
-  };
+  }
 
   /** Get the Nth from latest line of text in the terminal (unlike getInputLine) */
   function getTerminalLine(n) {
     if (n===undefined) n=0;
     var line = termText.length-(1+n);
     if (line<0) return undefined;
     return termText[line];
-  };
+  }
 
   /** Add a notification to the terminal (as HTML). If options.buttonclick is set
   then the first <button> inside the notification text

core/utils.js

@@ -19,13 +19,13 @@
 
   }
 
-  function decodeBase64(d) {
-    return Buffer.from(d,'base64').toString('binary');
-  }
+  // function decodeBase64(d) {
+  //   return Buffer.from(d,'base64').toString('binary');
+  // }
 
-  function encodeBase64(d) {
-    return Buffer.from(d,'binary').toString('base64');
-  }
+  // function encodeBase64(d) {
+  //   return Buffer.from(d,'binary').toString('base64');
+  // }
 
   function isWindows() {
     return (typeof navigator!="undefined") && navigator.userAgent.indexOf("Windows")>=0;
@@ -118,7 +118,7 @@
       while (s.length < len) s+=" ";
       return s;
     }
-  };
+  }
 
   /** Get a Lexer to parse JavaScript - this is really very nasty right now and it doesn't lex even remotely properly.
    * It'll return {type:"type", str:"chars that were parsed", value:"string", startIdx: Index in string of the start, endIdx: Index in string of the end}, until EOF when it returns undefined */
@@ -220,7 +220,7 @@
             if (ch=="\\") { // handle escape characters
               nextCh();
               var escape = '\\'+ch;
-              var escapeExtra = 0;
+              // var escapeExtra = 0;
               if (ch=="x") {
                 nextCh();escape += ch;
                 nextCh();escape += ch;
@@ -244,7 +244,7 @@
               value += ch;
             }
             nextCh();
-          };
+          }
           if (ch!==undefined) s+=ch;
           nextCh();
         }
@@ -260,7 +260,7 @@
     return {
       next : nextToken
     };
-  };
+  }
 
   /** Count brackets in a string - will be 0 if all are closed */
   function countBrackets(str) {
@@ -331,7 +331,7 @@
     };
     // send a newline, and we hope we'll see '=undefined\r\n>'
     Espruino.Core.Serial.write('\n');
-  };
+  }
 
   /** Return the value of executing an expression on the board. If
   If options.exprPrintsResult=false/undefined the actual value returned by the expression is returned.
@@ -436,7 +436,7 @@
       console.error("executeExpression called when not connected!");
       callback(undefined);
     }
-  };
+  }
 
   // Download a file - storageFile or normal file
   function downloadFile(fileName, callback) {
@@ -476,7 +476,7 @@ while (d!==undefined) {console.log(btoa(d));d=f.read(${CHUNKSIZE});}
 
   function versionToFloat(version) {
     return parseFloat(version.trim().replace("v","."));
-  };
+  }
 
   /// Gets a URL, and returns callback(data) or callback(undefined) on error. options={method:"GET/POST", data:{a:1,b:2}}
   function getURL(url, callback, options) {
@@ -610,7 +610,6 @@ while (d!==undefined) {console.log(btoa(d));d=f.read(${CHUNKSIZE});}
     return window.location.protocol=="https:";
   }
 
-
   /* Open a file load dialog.
   options = {
    id :  ID is to ensure that subsequent calls with  the same ID remember the last used directory.
@@ -724,7 +723,7 @@ while (d!==undefined) {console.log(btoa(d));d=f.read(${CHUNKSIZE});}
           window.URL.revokeObjectURL(url);
       }, 0);
     }
-  };
+  }
 
   /** Bluetooth device names that we KNOW run Espruino */
   var recongisedDevices = [
@@ -793,7 +792,7 @@ while (d!==undefined) {console.log(btoa(d));d=f.read(${CHUNKSIZE});}
       buf[i] = ch;
     }
     return buf.buffer;
-  };
+  }
 
   // Converts a string to a Buffer
   function stringToBuffer(str) {
@@ -802,7 +801,7 @@ while (d!==undefined) {console.log(btoa(d));d=f.read(${CHUNKSIZE});}
       buf.writeUInt8(str.charCodeAt(i), i);
     }
     return buf;
-  };
+  }
 
   // Converts a DataView to an ArrayBuffer
   function dataViewToArrayBuffer(dv) {
@@ -816,7 +815,7 @@ while (d!==undefined) {console.log(btoa(d));d=f.read(${CHUNKSIZE});}
   // Converts an ArrayBuffer to a string
   function arrayBufferToString(buf) {
     return String.fromCharCode.apply(null, new Uint8Array(buf));
-  };
+  }
 
   /* Parses a JSON string into JS, taking into account some of the issues
   with Espruino's JSON from 2v04 and before */
@@ -834,7 +833,7 @@ while (d!==undefined) {console.log(btoa(d));d=f.read(${CHUNKSIZE});}
       tok = lex.next();
     }
     return JSON.parse(final);
-  };
+  }
 
   /* Escape a string (like JSON.stringify) so that Espruino can understand it,
   however use \0,\1,\x,etc escapes whenever possible to make the String as small

plugins/assembler.js

@@ -480,7 +480,7 @@
              code;
     }
     callback(code);
-  };
+  }
 
 
   Espruino.Plugins.Assembler = {

plugins/compiler.js

@@ -53,8 +53,11 @@
   update node start/end positions of other nodes
   we're interested in */
   function replaceNode(node, newCode) {
+    // TODO: Where is 'code' defined? Is this a global?
     code = code.substr(0,node.start) + newCode + code.substr(node.end);
     var offs = newCode.length - (node.end-node.start); // offset for future code snippets
+
+    // TODO: Also unclear where 'tasks' is defined, there's nothing in this scope to declare it
     for (var i in tasks)
       if (tasks[i].node.start > node.start) {
         tasks[i].node.start += offs;
@@ -67,7 +70,7 @@
       return callback(code);
 
     var board = Espruino.Core.Env.getBoardData();
-    var tasks = 0;
+    var tasks = 0; // TODO: This is re-declared as an array at #73, but this outer scoped 'tasks' is not modified
     try {
       var ast = acorn.parse(code);
       var tasks = [];

plugins/minify.js

@@ -194,6 +194,8 @@
         _callback(code);
       };
     })();
+    
+    // TODO: None of the below block is called
     var minifyCode = code;
     var minifyCallback = callback;
     if (isModule) {
@@ -206,6 +208,7 @@
         callback(minified.substr(header.length, minified.length-(header.length+footer.length+1)));
       }
     }
+    // End of unused block
 
     switch(level){
       case "WHITESPACE_ONLY":