Skip to content

Commit f7e8c91

Browse files
committed
Temporarily enable RaftAsyncStorageWrites to validate in CI
Signed-off-by: Michael Shen <mishen@umich.edu>
1 parent 3b07707 commit f7e8c91

2 files changed

Lines changed: 11 additions & 1 deletion

File tree

server/embed/config_test.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ func TestConfigFileFeatureGates(t *testing.T) {
112112
features.LeaseCheckpoint: false,
113113
features.LeaseCheckpointPersist: false,
114114
features.FastLeaseKeepAlive: true,
115+
features.RaftAsyncStorageWrites: true, // TODO(mjlshen): Temporary to validate this in CI
115116
},
116117
},
117118
{
@@ -121,6 +122,7 @@ func TestConfigFileFeatureGates(t *testing.T) {
121122
features.StopGRPCServiceOnDefrag: true,
122123
features.TxnModeWriteWithSharedBuffer: true,
123124
features.FastLeaseKeepAlive: true,
125+
features.RaftAsyncStorageWrites: true, // TODO(mjlshen): Temporary to validate this in CI
124126
},
125127
},
126128
{
@@ -130,6 +132,7 @@ func TestConfigFileFeatureGates(t *testing.T) {
130132
features.InitialCorruptCheck: true,
131133
features.TxnModeWriteWithSharedBuffer: true,
132134
features.FastLeaseKeepAlive: true,
135+
features.RaftAsyncStorageWrites: true, // TODO(mjlshen): Temporary to validate this in CI
133136
},
134137
},
135138
{
@@ -139,6 +142,7 @@ func TestConfigFileFeatureGates(t *testing.T) {
139142
features.StopGRPCServiceOnDefrag: false,
140143
features.TxnModeWriteWithSharedBuffer: true,
141144
features.FastLeaseKeepAlive: true,
145+
features.RaftAsyncStorageWrites: true, // TODO(mjlshen): Temporary to validate this in CI
142146
},
143147
},
144148
{
@@ -147,6 +151,7 @@ func TestConfigFileFeatureGates(t *testing.T) {
147151
expectedFeatures: map[featuregate.Feature]bool{
148152
features.TxnModeWriteWithSharedBuffer: true,
149153
features.FastLeaseKeepAlive: true,
154+
features.RaftAsyncStorageWrites: true, // TODO(mjlshen): Temporary to validate this in CI
150155
},
151156
},
152157
{
@@ -155,6 +160,7 @@ func TestConfigFileFeatureGates(t *testing.T) {
155160
expectedFeatures: map[featuregate.Feature]bool{
156161
features.TxnModeWriteWithSharedBuffer: false,
157162
features.FastLeaseKeepAlive: true,
163+
features.RaftAsyncStorageWrites: true, // TODO(mjlshen): Temporary to validate this in CI
158164
},
159165
},
160166
{
@@ -164,6 +170,7 @@ func TestConfigFileFeatureGates(t *testing.T) {
164170
features.CompactHashCheck: true,
165171
features.TxnModeWriteWithSharedBuffer: true,
166172
features.FastLeaseKeepAlive: true,
173+
features.RaftAsyncStorageWrites: true, // TODO(mjlshen): Temporary to validate this in CI
167174
},
168175
},
169176
{
@@ -174,6 +181,7 @@ func TestConfigFileFeatureGates(t *testing.T) {
174181
features.LeaseCheckpoint: true,
175182
features.LeaseCheckpointPersist: true,
176183
features.FastLeaseKeepAlive: true,
184+
features.RaftAsyncStorageWrites: true, // TODO(mjlshen): Temporary to validate this in CI
177185
},
178186
},
179187
{
@@ -182,6 +190,7 @@ func TestConfigFileFeatureGates(t *testing.T) {
182190
expectedFeatures: map[featuregate.Feature]bool{
183191
features.TxnModeWriteWithSharedBuffer: true,
184192
features.FastLeaseKeepAlive: false,
193+
features.RaftAsyncStorageWrites: true, // TODO(mjlshen): Temporary to validate this in CI
185194
},
186195
},
187196
}

server/features/etcd_features.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,8 @@ var DefaultEtcdServerFeatureGates = map[featuregate.Feature]featuregate.FeatureS
102102
SetMemberLocalAddr: {Default: false, PreRelease: featuregate.Alpha},
103103
FastLeaseKeepAlive: {Default: true, PreRelease: featuregate.Beta},
104104
PriorityRequest: {Default: false, PreRelease: featuregate.Alpha},
105-
RaftAsyncStorageWrites: {Default: false, PreRelease: featuregate.Alpha},
105+
// TODO(mjlshen): Default to true to validate this in CI, should default to false
106+
RaftAsyncStorageWrites: {Default: true, PreRelease: featuregate.Alpha},
106107
}
107108

108109
func NewDefaultServerFeatureGate(name string, lg *zap.Logger) featuregate.FeatureGate {

0 commit comments

Comments
 (0)