Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CI job to "tidy" all the config files #303

Open
geoknee opened this issue Jun 21, 2024 · 1 comment
Open

Add a CI job to "tidy" all the config files #303

geoknee opened this issue Jun 21, 2024 · 1 comment

Comments

@geoknee
Copy link
Collaborator

geoknee commented Jun 21, 2024

This is to keep the formatting strictly adhered to.

It should be a local tool which overwrites the raw config yml files using the Go bindings/types. This way it will serve as a double check on our marshalling / unmarshaling code.

We then run the tool in CI and run git diff --exit-code.

Should we make a CI job to "tidy" all the config files, to keep the formatting strictly adhered to?

Originally posted by @geoknee in #279 (comment)

@geoknee
Copy link
Collaborator Author

geoknee commented Jun 21, 2024

This job can also enforce that superchain_level: 2 and standard_chain_candidate = true should not both appear in a config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant