Replace builder_index with opaque bytes in RequestAuth#149
Draft
JasonVranek wants to merge 38 commits into
Draft
Replace builder_index with opaque bytes in RequestAuth#149JasonVranek wants to merge 38 commits into
JasonVranek wants to merge 38 commits into
Conversation
9d5be35 to
3b5735b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We require per-builder authorization on
GET /execution_payload_bidandPOST /validatorsto prevent builder-to-builder replay attacks. The current PR changed the authorization data from a builderurltobuilder_index. A singlebuilder_indexis insufficient as it is likely there isn't a 1:1 relationship between a URLs and indices which will result in the validator needing to generate multiple signatures and make multiple redundant requests to the same URL. The same reasoning applies ifbuilder_indexis replaced bybuilder_pubkey.The purpose of this PR is to future proof ourselves by generalizing the
RequestAuthstruct to:Having
messageas opaque bytes allows for arbitrary authorization schemes to be used in the future. For examplemessagecan encode a builder's URL or something more complicated, as long as the builder understands how to interpret the bytes.