feat(tests): Typed txs are invalid and void before their fork

Author: pdobacz

packages/testing/src/execution_testing/client_clis/clis/ethrex.py

@@ -50,6 +50,9 @@ class EthrexExceptionMapper(ExceptionMapper):
         TransactionException.TYPE_3_TX_INVALID_BLOB_VERSIONED_HASH: (
             r"blob version not supported|Invalid blob versioned hash"
         ),
+        TransactionException.TYPE_3_TX_PRE_FORK: (
+            r"Type 2 transactions are not supported before the London fork"
+        ),
         TransactionException.TYPE_3_TX_PRE_FORK: (
             r"blob versioned hashes not supported|"
             r"Type 3 transactions are not supported before the Cancun fork"

packages/testing/src/execution_testing/client_clis/clis/evmone.py

@@ -350,6 +350,7 @@ class EvmoneExceptionMapper(ExceptionMapper):
         ),
         TransactionException.TYPE_4_TX_PRE_FORK: "transaction type not supported",
         TransactionException.TYPE_3_TX_PRE_FORK: "transaction type not supported",
+        TransactionException.TYPE_2_TX_PRE_FORK: "transaction type not supported",
         TransactionException.TYPE_3_TX_INVALID_BLOB_VERSIONED_HASH: "invalid blob hash version",
         TransactionException.TYPE_3_TX_BLOB_COUNT_EXCEEDED: "blob gas limit exceeded",
         TransactionException.TYPE_3_TX_ZERO_BLOBS: "empty blob hashes list",

packages/testing/src/execution_testing/client_clis/clis/geth.py

@@ -54,6 +54,9 @@ class GethExceptionMapper(ExceptionMapper):
         TransactionException.PRIORITY_GREATER_THAN_MAX_FEE_PER_GAS: (
             "max priority fee per gas higher than max fee per gas"
         ),
+        TransactionException.TYPE_2_TX_PRE_FORK: (
+            "transaction type not supported"
+        ),
         TransactionException.TYPE_3_TX_PRE_FORK: (
             "transaction type not supported"
         ),

packages/testing/src/execution_testing/client_clis/clis/nethermind.py

@@ -395,6 +395,9 @@ class NethermindExceptionMapper(ExceptionMapper):
         TransactionException.INSUFFICIENT_MAX_FEE_PER_BLOB_GAS: (
             "InsufficientMaxFeePerBlobGas: Not enough to cover blob gas fee"
         ),
+        TransactionException.TYPE_2_TX_PRE_FORK: (
+            "InvalidTxType: Transaction type in Custom is not supported"
+        ),
         TransactionException.TYPE_3_TX_PRE_FORK: (
             "InvalidTxType: Transaction type in Custom is not supported"
         ),

packages/testing/src/execution_testing/exceptions/exceptions.py

@@ -269,6 +269,8 @@ class TransactionException(ExceptionBase):
     """
     Transaction's initcode for a contract-creating transaction is too large.
     """
+    TYPE_2_TX_PRE_FORK = auto()
+    """Transaction type 3 included before activation fork."""
     TYPE_3_TX_PRE_FORK = auto()
     """Transaction type 3 included before activation fork."""
     TYPE_3_TX_ZERO_BLOBS_PRE_FORK = auto()

packages/testing/src/execution_testing/exceptions/exceptions/transaction.py

@@ -153,6 +153,8 @@ class TransactionException(ExceptionBase):
     """
     Transaction's initcode for a contract-creating transaction is too large.
     """
+    TYPE_2_TX_PRE_FORK = auto()
+    """Transaction type 2 included before activation fork."""
     TYPE_3_TX_PRE_FORK = auto()
     """Transaction type 3 included before activation fork."""
     TYPE_3_TX_ZERO_BLOBS_PRE_FORK = auto()

tests/london/__init__.py

@@ -0,0 +1 @@
+"""Test cases for EVM functionality introduced in London."""

tests/london/validation/__init__.py

@@ -0,0 +1,3 @@
+"""
+Test for validation rules that apply for all forks starting from London.
+"""

tests/london/validation/test_tx_type.py

@@ -0,0 +1,71 @@
+"""Test the tx type validation for EIP-1559."""
+
+import pytest
+from execution_testing.base_types.composite_types import Account, Alloc
+from execution_testing.exceptions.exceptions import TransactionException
+from execution_testing.forks import Byzantium, London
+from execution_testing.forks.helpers import Fork
+from execution_testing.specs.state import StateTestFiller
+from execution_testing.test_types.block_types import Environment
+from execution_testing.test_types.transaction_types import Transaction
+from execution_testing.vm import Opcodes as Op
+from requests_cache import Callable
+
+
+@pytest.fixture
+def eip1559_tx_validity_test(
+    state_test: StateTestFiller, pre: Alloc, fork: Fork, env: Environment
+) -> Callable[[], None]:
+    """
+    Returns a function which applies a `state_test`, where a typed transaction
+    is either valid and has an effect on state or not, depending on the fork.
+    """
+
+    def test_function() -> None:
+        valid = fork >= London
+
+        account = pre.deploy_contract(
+            code=Op.SSTORE(0, 1),
+            storage={0: 0xDEADBEEF},
+        )
+        sender = pre.fund_eoa()
+
+        tx = Transaction(
+            to=account,
+            sender=sender,
+            gas_limit=100_000,
+            max_priority_fee_per_gas=1,
+            protected=fork >= Byzantium,
+            error=TransactionException.TYPE_2_TX_PRE_FORK
+            if not valid
+            else None,
+        )
+
+        post = {account: Account(storage={0: 0xDEADBEEF if not valid else 1})}
+        if not valid:
+            post[sender] = pre[sender]
+
+        state_test(env=env, pre=pre, post=post, tx=tx)
+
+    return test_function
+
+
+@pytest.mark.exception_test
+@pytest.mark.valid_until("Berlin")
+def test_eip1559_tx_invalid(
+    eip1559_tx_validity_test: Callable[[], None],
+) -> None:
+    """
+    Tests that an EIP-1559 tx has no effect before London.
+    """
+    eip1559_tx_validity_test()
+
+
+@pytest.mark.valid_from("London")
+def test_eip1559_tx_valid(
+    eip1559_tx_validity_test: Callable[[], None],
+) -> None:
+    """
+    Tests that an EIP-1559 tx has an effect after London.
+    """
+    eip1559_tx_validity_test()