-
Notifications
You must be signed in to change notification settings - Fork 25
Description
Describe the bug
Hello !
It seems that the new version of the jms/serializer dependency breaks the Eversign SDK.
As can be seen in the jms/serializer 3.30.0 release, doctrine/annotation is now optional and this seems to cause problems that prevent your package from working properly. Using the client causes this error :
You must define a type for Eversign\\Business::$businessId
This isn't the first time these two packages and their updates have caused a problem and prevented the Eversign SDK from working properly : #74 #75 #81
So I think it would be safer to part with your use of doctrine/annotation now or find a way to make it work without problem at every update...
I haven't managed to figure out exactly what's causing the bug here, but I can confirm that it does come from version 3.30.0 of jms/serializer. I was able to get round this problem temporarily by fixing the versions on my side :
"eversign/eversign-php-sdk": "1.27.0",
"jms/serializer": "3.29.1",
"doctrine/annotations": "1.14.3",
It is becoming urgent to deal with all problem of doctrine/annotation that this package can continue to be used without blocking users.
To Reproduce
Use the EverSign client with a fresh composer update
eversign-php-sdk:1.27.0jms/serializer:3.30.0
$client = new Client(
config('services.eversign.key'),
config('services.eversign.id')
);
Error 500 ➡️ You must define a type for Eversign\\Business::$businessId
Thank you in advance!