jenkins: add lint and test stages

Author: Hans Kristian Flaatten

.dockerignore

@@ -0,0 +1,3 @@
+app/.eslintrc.json
+app/test.js
+app/yarn.lock

Dockerfile

@@ -2,10 +2,6 @@ FROM node:8-alpine
 
 WORKDIR /usr/src/app
 
-ADD ./app/package.json ./app/yarn.lock /usr/src/app/
-
-RUN yarn install --production && yarn cache clean
-
 ADD ./app /usr/src/app/
 
 CMD [ "node", "index.js" ]

Jenkinsfile

@@ -26,12 +26,36 @@ node('jenkins-docker-2') {
         checkout scm
       }
 
-      stage('Build') {
+      stage('Install') {
+        docker.image('node:8-alpine').inside() {
+          sh 'yarn install --development'
+        }
+      }
+
+      stage('Lint') {
+        docker.image('node-8-alpine').inside() {
+          sh 'yarn run lint'
+        }
+      }
+
+      stage('Test') {
+        docker.image('node-8-alpine').inside() {
+          sh 'yarn run test'
+        }
+      }
+
+      stage('Prune') {
+        docker.image('node-8-alpine').inside() {
+          sh 'yarn install --production'
+        }
+      }
+
+      stage('Docker Build') {
         conf.DOCKER_IMAGE = "${conf.REGISTRY}/${conf.NAME}:${conf.TAG}"
         image = docker.build(conf.DOCKER_IMAGE)
       }
 
-      stage('Push') {
+      stage('Docker Push') {
         docker.withRegistry("https://${conf.REGISTRY}", conf.REGISTRY) {
           image.push()
         }

app/.eslintrc.json

@@ -0,0 +1,6 @@
+{
+    "extends": "airbnb-base",
+    "plugins": [
+        "import"
+    ]
+}

app/index.js

@@ -1,10 +1,12 @@
-const express = require('express')
-const app = express()
+const express = require('express');
 
-app.get('/', function (req, res) {
-  res.send('Hello World!')
-})
+const app = express();
 
-app.listen(3000, function () {
-  console.log('Example app listening on port 3000!')
-})
+app.get('/', (req, res) => res.send('Hello World!'));
+
+if (!module.parent) {
+  // eslint-disable-next-line no-console
+  app.listen(3000, () => console.log('Example app listening on port 3000!'));
+}
+
+module.exports = app;

app/package.json

@@ -8,5 +8,16 @@
   "license": "MIT",
   "dependencies": {
     "express": "^4.15.3"
+  },
+  "devDependencies": {
+    "ava": "^0.19.1",
+    "eslint": "^4.0.0",
+    "eslint-config-airbnb-base": "^11.2.0",
+    "eslint-plugin-import": "^2.5.0",
+    "supertest": "^3.0.0"
+  },
+  "scripts": {
+    "test": "ava",
+    "lint": "eslint *.js"
   }
 }

app/test.js

@@ -0,0 +1,16 @@
+import supertest from 'supertest';
+
+import test from 'ava';
+
+import app from '.';
+
+const req = supertest(app);
+
+test('index', async (t) => {
+  t.plan(2);
+
+  const res = await req.get('/');
+
+  t.is(res.status, 200);
+  t.is(res.text, 'Hello World!');
+});