allow scale to zero

davidkarlsen · davidkarlsen · commit 66653aa9fcd3 · 2022-06-05T21:47:06.000+02:00
diff --git a/controllers/githubactionrunner_controller.go b/controllers/githubactionrunner_controller.go
@@ -173,7 +173,7 @@ func shouldScaleUp(podRunnerPairs podRunnerPairList, instance *garov1alpha1.Gith
 }
 
 func shouldScaleDown(podRunnerPairs podRunnerPairList, instance *garov1alpha1.GithubActionRunner) bool {
-	return podRunnerPairs.numRunners() > instance.Spec.MaxRunners || (podRunnerPairs.numIdle() > 1 && (podRunnerPairs.numRunners() > instance.Spec.MinRunners))
+	return podRunnerPairs.numRunners() > instance.Spec.MaxRunners || (podRunnerPairs.numIdle() > 0 && (podRunnerPairs.numRunners() > instance.Spec.MinRunners))
 }
 
 func (r *GithubActionRunnerReconciler) manageOutcome(ctx context.Context, instance *garov1alpha1.GithubActionRunner, issue error) (reconcile.Result, error) {

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ func shouldScaleUp(podRunnerPairs podRunnerPairList, instance *garov1alpha1.Gith`
`173`	`173`	`}`
`174`	`174`
`175`	`175`	`func shouldScaleDown(podRunnerPairs podRunnerPairList, instance *garov1alpha1.GithubActionRunner) bool {`
`176`		`- return podRunnerPairs.numRunners() > instance.Spec.MaxRunners \|\| (podRunnerPairs.numIdle() > 1 && (podRunnerPairs.numRunners() > instance.Spec.MinRunners))`
	`176`	`+ return podRunnerPairs.numRunners() > instance.Spec.MaxRunners \|\| (podRunnerPairs.numIdle() > 0 && (podRunnerPairs.numRunners() > instance.Spec.MinRunners))`
`177`	`177`	`}`
`178`	`178`
`179`	`179`	`func (r GithubActionRunnerReconciler) manageOutcome(ctx context.Context, instance garov1alpha1.GithubActionRunner, issue error) (reconcile.Result, error) {`