-
Notifications
You must be signed in to change notification settings - Fork 17
Open
Labels
Description
Hi there - just a heads up;
You're currently registering your keybinds in the constructor of ClientRenderHandler, as seen here:
https://github.com/unascribed/BlockRenderer/blob/914264f1415cf7f1b13f90e82234cceec918e3df/src/main/java/com/unascribed/blockrenderer/ClientRenderHandler.java#L81
This is somewhat ok, but it breaks development environments which contain your mod, and it shouldn't be done there anyway.
This happens because some dev runtimes don't actually let Minecraft assign an instance (such as datagen), which causes this line to NPE because it's being called when it shouldn't be.
Can you move this to FMLClientSetupEvent, where it should be?
I'd do a PR but I'm not able to do so currently due to being away from my main dev setup