Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: zstandard support #586

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: zstandard support #586

wants to merge 1 commit into from
+107 −5

Conversation

Phillip9587
Copy link
Contributor

@Phillip9587 Phillip9587 commented Feb 13, 2025 •
edited
Loading

This PR introduces support for the Zstandard (Zstd) algorithm, which was released as an experimental feature in Node.js 23.8.0.

Key Changes

  • Adds support for Zstandard (Zstd) as an optional compression algorithm.

Notes

  • This feature is experimental and subject to changes in future Node.js releases.
  • Requires Node.js 23.8.0+ to function correctly.

closes #560

bjohansebas
bjohansebas suggested changes Feb 13, 2025
View reviewed changes
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really prefer to wait until the API becomes stable. This is the same stance I’m going to take with compression. There may be no changes during the transition from experimental to stable, but it’s better to use only stable APIs

Great job anyway!

wesleytodd
wesleytodd requested changes Mar 5, 2025
View reviewed changes
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, we should wait until it is stable then just enable support without an experimental phase.

@Phillip9587 Phillip9587 changed the title feat: experimental zstandard support feat: zstandard support Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleytodd wesleytodd wesleytodd requested changes

@bjohansebas bjohansebas bjohansebas requested changes

@UlisesGascon UlisesGascon Awaiting requested review from UlisesGascon

Assignees
No one assigned
Labels
future
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zstd support?
3 participants
@Phillip9587 @wesleytodd @bjohansebas