Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cors Demo in Documentation Link broken #343

Open
monsterrave opened this issue Mar 4, 2025 · 4 comments · May be fixed by #344
Open

Cors Demo in Documentation Link broken #343

monsterrave opened this issue Mar 4, 2025 · 4 comments · May be fixed by #344

Comments

@monsterrave
Copy link

Description

unfortunately, the link to the cors demo is not working
https://node-cors-client.netlify.com/

Expectations

link should work

@wesleytodd
Copy link
Member

PR's welcome! If you cannot submit a PR, please tell us where you are seeing this broken link.

@monsterrave
Copy link
Author

Sorry, my bad. in the demo section, the first link

https://expressjs.com/en/resources/middleware/cors.html#:~:text=on%20web.dev.-,Demo,-A%20demo%20that

@wesleytodd wesleytodd transferred this issue from expressjs/express Mar 4, 2025
@wesleytodd
Copy link
Member

I moved the issue to the proper repo. This can probably be removed as it is likely whoever built that is no longer working in the project.

@dpopp07
Copy link

dpopp07 commented Mar 4, 2025

I noticed this recently as well and meant to open a PR, but lost track.

I am in favor of removing the link for a cleaner README. I don't believe there is a "correct" link at the moment - the app is just not being hosted anywhere.

If we want to get it up and running again, we can open an issue for it, label it as "help wanted", and see if someone wants to take over the project.

Unless you're going to @monsterrave, I'll open a PR to remove the link this week.

@dpopp07 dpopp07 linked a pull request Mar 10, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants