Skip to content

Commit 5d5b51f

Browse files
committed
tests: resolve originalMaxAge flaky tests
fixes #719
1 parent ac3f0a2 commit 5d5b51f

File tree

1 file changed

+35
-5
lines changed

1 file changed

+35
-5
lines changed

test/session.js

Lines changed: 35 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1902,7 +1902,13 @@ describe('session()', function(){
19021902

19031903
request(server)
19041904
.get('/')
1905-
.expect(200, '2000', done)
1905+
.expect(200)
1906+
.expect(function (res) {
1907+
// account for 1ms latency
1908+
assert.ok(res.text === '2000' || res.text === '1999',
1909+
'expected 2000, got ' + res.text)
1910+
})
1911+
.end(done)
19061912
})
19071913

19081914
it('should equal original maxAge for all requests', function (done) {
@@ -1912,13 +1918,25 @@ describe('session()', function(){
19121918

19131919
request(server)
19141920
.get('/')
1915-
.expect(200, '2000', function (err, res) {
1921+
.expect(200)
1922+
.expect(function (res) {
1923+
// account for 1ms latency
1924+
assert.ok(res.text === '2000' || res.text === '1999',
1925+
'expected 2000, got ' + res.text)
1926+
})
1927+
.end(function (err, res) {
19161928
if (err) return done(err)
19171929
setTimeout(function () {
19181930
request(server)
19191931
.get('/')
19201932
.set('Cookie', cookie(res))
1921-
.expect(200, '2000', done)
1933+
.expect(200)
1934+
.expect(function (res) {
1935+
// account for 1ms latency
1936+
assert.ok(res.text === '2000' || res.text === '1999',
1937+
'expected 2000, got ' + res.text)
1938+
})
1939+
.end(done)
19221940
}, 100)
19231941
})
19241942
})
@@ -1931,13 +1949,25 @@ describe('session()', function(){
19311949

19321950
request(server)
19331951
.get('/')
1934-
.expect(200, '2000', function (err, res) {
1952+
.expect(200)
1953+
.expect(function (res) {
1954+
// account for 1ms latency
1955+
assert.ok(res.text === '2000' || res.text === '1999',
1956+
'expected 2000, got ' + res.text)
1957+
})
1958+
.end(function (err, res) {
19351959
if (err) return done(err)
19361960
setTimeout(function () {
19371961
request(server)
19381962
.get('/')
19391963
.set('Cookie', cookie(res))
1940-
.expect(200, '2000', done)
1964+
.expect(200)
1965+
.expect(function (res) {
1966+
// account for 1ms latency
1967+
assert.ok(res.text === '2000' || res.text === '1999',
1968+
'expected 2000, got ' + res.text)
1969+
})
1970+
.end(done)
19411971
}, 100)
19421972
})
19431973
})

0 commit comments

Comments
 (0)