Skip to content

Commit 43c7330

Browse files
authored
Merge pull request #68 from extractus/review-pr67
v6.1.6
2 parents 223f07e + b726488 commit 43c7330

File tree

8 files changed

+23
-17
lines changed

8 files changed

+23
-17
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ cd feed-extractor
5858
npm test
5959
```
6060

61-
![feed-extractor unit test](https://i.imgur.com/xTwZK6B.png)
61+
![feed-extractor unit test](https://i.imgur.com/2b5xt6S.png)
6262

6363
If test coverage decreased, please check test scripts and try to improve this number.
6464

README.md

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,6 @@ import { read } from 'https://unpkg.com/@extractus/feed-extractor@latest/dist/fe
7070

7171
Please check [the examples](https://github.com/extractus/feed-extractor/tree/main/examples) for reference.
7272

73-
### Deta cloud
74-
75-
For [Deta](https://www.deta.sh/) devs please refer [the source code and guideline here](https://github.com/ndaidong/feed-reader-deta) or simply click the button below.
76-
77-
[![Deploy](https://button.deta.dev/1/svg)](https://go.deta.dev/deploy?repo=https://github.com/ndaidong/feed-reader-deta)
78-
7973

8074
## APIs
8175

@@ -220,7 +214,19 @@ await read(url, null, {
220214
})
221215
```
222216

223-
Passing requests to proxy is useful while running `@extractus/feed-extractor` on browser. View `examples/browser-feed-reader` as reference example.
217+
Passing requests to proxy is useful while running `@extractus/feed-extractor` on browser.
218+
View `examples/browser-feed-reader` as reference example.
219+
220+
## Test
221+
222+
```bash
223+
git clone https://github.com/extractus/feed-extractor.git
224+
cd feed-extractor
225+
npm i
226+
npm test
227+
```
228+
229+
![feed-extractor-test.png](https://i.imgur.com/2b5xt6S.png)
224230

225231

226232
## Quick evaluation

dist/cjs/feed-extractor.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/cjs/index.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,11 @@ export interface ReaderOptions {
5656
/**
5757
* merge extra feed fields in result
5858
*/
59-
extraFeedFields?: (feedData: object) => object;
59+
getExtraFeedFields?: (feedData: object) => object;
6060
/**
6161
* merge extra entry fields in result
6262
*/
63-
extraEntryFields?: (entryData: object) => object;
63+
getExtraEntryFields?: (entryData: object) => object;
6464
}
6565

6666
export interface FetchOptions {

dist/cjs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"name": "@extractus/feed-extractor",
3-
"version": "6.1.5",
3+
"version": "6.1.6",
44
"main": "./feed-extractor.js"
55
}

dist/feed-extractor.esm.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// @extractus/[email protected].5, by @extractus - built with esbuild at 2022-12-02T14:07:13.301Z - published under MIT license
1+
// @extractus/[email protected].6, by @extractus - built with esbuild at 2022-12-05T01:51:24.880Z - published under MIT license
22
var __create = Object.create;
33
var __defProp = Object.defineProperty;
44
var __getOwnPropDesc = Object.getOwnPropertyDescriptor;

index.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,11 @@ export interface ReaderOptions {
5656
/**
5757
* merge extra feed fields in result
5858
*/
59-
extraFeedFields?: (feedData: object) => object;
59+
getExtraFeedFields?: (feedData: object) => object;
6060
/**
6161
* merge extra entry fields in result
6262
*/
63-
extraEntryFields?: (entryData: object) => object;
63+
getExtraEntryFields?: (entryData: object) => object;
6464
}
6565

6666
export interface FetchOptions {

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "6.1.5",
2+
"version": "6.1.6",
33
"name": "@extractus/feed-extractor",
44
"description": "To read and normalize RSS/ATOM/JSON feed data",
55
"homepage": "https://github.com/extractus/feed-extractor",
@@ -40,7 +40,7 @@
4040
},
4141
"devDependencies": {
4242
"args-parser": "^1.3.0",
43-
"esbuild": "^0.15.16",
43+
"esbuild": "^0.15.17",
4444
"jest": "^29.3.1",
4545
"nock": "^13.2.9",
4646
"standard": "^17.0.0"

0 commit comments

Comments
 (0)