-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: support for links (and maybe links previews) #74
Comments
I spent a little time looking at this. One approach could be to change For backwards compatibility, we could continue to offer initialisers that use I'd be interested to pick this up, would that be ok? If so, if there are any suggestions / improvements for the approach, I'd love to hear them :) |
Hey @matthewrfennell, that would be most appreciated, no extra suggestions, sounds good |
Hey @matthewrfennell, looks wonderful! Hardcoding is bad, but I know what Apple is like, so I guess we don't have choice. Why do you want to disable tap on reply messages though? Tapping a link there should be ok too, or did I misunderstand that part? Everything else sounds great. Thank you so much for all your support of this library, have a marvellous day! |
Great, thank you!
My thinking was that it might confuse users if they tap a reply message (perhaps expecting it to scroll them back to the original message) and the link opens. That said, I see attachments in reply messages are clickable, so now I think agree we should leave the tap handler there, and only remove it if we implement scrolling back to a previous message on tap. I'll get working on it :) thanks for the feedback! |
Love this library 💯 would be really cool to see support for links, and for allowing to copy messages. Right now the long press just makes the "Reply" button show up.
The text was updated successfully, but these errors were encountered: