Added docs about testing

Author: Jesse Eichar

README.md

@@ -411,3 +411,34 @@ Some resources for these annotations are:
 * http://minds.coremedia.com/2012/10/31/jsr-305-nonnull-and-guava-preconditions/
 * http://findbugs.sourceforge.net/manual/annotations.html (the package names are outof date
    and should be java.annotation instead of edu.umd.cs.findbugs.annotation but the descriptions are accurate)
+
+# Testing
+
+With regards to testing Geonetwork is a standard Java project and primarily depends on JUnit for testing.  However there is a very important
+issue to consider when writing JUnit tests in Geonetwork and that is the separation between unit tests and integration tests
+
+* *Unit Tests* - In Geonetwork unit tests should be very very quick to execute and not start up any subsystems of the application in order to keep
+    the execution time of the unit tests very short.  Integration tests do not require super classes and any assistance methods can be static
+    imports, for example statically importing org.junit.Assert or org.junit.Assume or org.fao.geonet.Assert.
+* *Integration Tests* - Integration Test typically start much or all of Geonetwork as part of the test and will take longer to run than
+    a unit test.  However, even though the tests take longer they should still be implemented in such a way to be as efficient as possible.
+    Starting Geonetwork in a way that isolates each integration test from each other integration test is non-trivial.  Because of this
+    there are `abstract` super classes to assist with this.  Many modules have module specific Abstract classes.  For example at the time
+    that this is being written `domain`, `core`, `harvesters` and `services` modules all have module specific super classes that need to
+    be used.  (`harvesting` has 2 superclasses depending on what is to be tested.)
+    The easiest way to learn how to implement an integration test is to search for other integration tests in the same module as the class
+    you want to test.  The following list provides a few tips:
+    * *IMPORTANT*: All Integrations tests *must* end in IntegrationTest.  The build system assumes all tests ending in IntegrationTest is
+        an integration test and runs them in a build phase after unit tests.  All other tests are assumed to be unit tests.
+    * Prefer unit tests over Integration Tests because they are faster.
+    * Search the current module for IntegrationTest to find tests to model your integration test against
+    * This you might want integration tests for are:
+        * Services: If the service already exists and you quick need to write a test to debug/fix its behaviour.
+                    If you are writing a new service it is better to use Mockito to mock the dependencies of the service so the test is
+                    a unit test.
+        * Harvesters
+        * A behaviour that crosses much of the full system
+
+*org.fao.geonet.utils.GeonetHttpRequestFactory*: When making Http requests you should use org.fao.geonet.utils.GeonetHttpRequestFactory instead
+    of directly using HttpClient.  This is because there are mock instances of org.fao.geonet.utils.GeonetHttpRequestFactory that can
+    be used to mock responses when performing tests.

core/src/test/java/org/fao/geonet/test/GeonetworkTestCase.java core/src/test/java/org/fao/geonet/Assert.java

@@ -1,4 +1,4 @@
-package org.fao.geonet.test;
+package org.fao.geonet;
 
 import java.util.Collection;
 
@@ -7,7 +7,7 @@
  *
  * @author heikki doeleman
  */
-public class GeonetworkTestCase extends junit.framework.TestCase {
+public final class Assert extends junit.framework.TestCase {
 
     /**
      * Just to prevent junit.framework.AssertionFailedError: No tests found in org.fao.geonet.test.TestCase.
@@ -29,25 +29,4 @@ public static void assertContains(String msg, Object o, Collection<?> c) {
         }
         fail(msg);
     }
-
-    /**
-     * No-arg constructor to enable serialization. This method is not intended to be used by mere mortals without
-     * calling setName().
-     */
-    public GeonetworkTestCase() {
-        super();
-    }
-    /**
-     * Constructs a test case with the given name.
-     */
-    public GeonetworkTestCase(String name) {
-        super(name);
-    }
-    /**
-     * Sets the name of a TestCase.
-     * @param name the name to set
-     */
-    public void setName(String name) {
-        super.setName(name);
-    }
 }

core/src/test/java/org/fao/geonet/util/xml/NamespaceUtilsTest.java

@@ -1,9 +1,10 @@
 package org.fao.geonet.util.xml;
 
+import static org.fao.geonet.Assert.*;
 import org.fao.geonet.utils.Xml;
-import org.fao.geonet.test.GeonetworkTestCase;
 import org.jdom.Element;
 import org.jdom.Namespace;
+import org.junit.Test;
 
 import java.util.List;
 
@@ -14,12 +15,9 @@
  * @author heikki doeleman
  *
  */
-public class NamespaceUtilsTest extends GeonetworkTestCase {
-
-    public NamespaceUtilsTest(String name) throws Exception {
-		super(name);
-	}
+public class NamespaceUtilsTest {
 
+    @Test
     public void testNamespaceInScope() throws Exception {
         String xml = "<?xml version=\"1.0\"?><root " +
                 "xmlns:a=\"http://aaa\" " +