Replies: 1 comment 4 replies
-
|
It is hard to guess without seeing your code, template, or package file, but:
I've been able to get v4 to work, but v5 doesn't seem to be working, it may need additional set up that is not (yet) documented by |
Beta Was this translation helpful? Give feedback.
-
|
many thanks @npetruzzelli I'm using create-react-app with this custom template, all packages are added to the template and then relies on react-scripts process to install everything.
|
Beta Was this translation helpful? Give feedback.
-
|
If you are going to be using yarn, you will want to create the react app using yarn. Replace
if yarn is installed on your computer and you want to use npm, you'll have to explicitly tell CRA that with
This is the code responsible for installing the dependencies from the template. It uses cross-spawn to get the job done. The arguments end up being no different than if you were to manually type it in: I had to set a user level environment variable When using npm (with I encounter the following error: I looked in the The behavior is different when using yarn. When using npm, you have the option of When using Yarn, I can confirm that the hooks are never created. Without the hooks, the build doesn't fail, which is probably why the error encountered with npm does not happen with yarn. It looks like you have 2 separate issues to work on (npm and yarn). In the end the solution may require you to fork your own version of If all you are doing is customizing the init script, the final repo should still be able to use I don't know if CRA will attempt to tackle this because their existing documentation for manually adding it after CRA has initialized the repo does work. It is almost the same as you changing directory and manually adding husky. I am a bit lost with the problem with yarn. It may have to do with the install scripts in the husky repository. It seems to work with CRA installs using npm and manual installs using npm and yarn... so why does it not work with CRA using yarn? Is it a CRA problem? a cross-spawn problem? a yarn problem? a husky problem? Again, you may need a custom init script if you aren't able to resolve it with the four projects involved. I'm not a contributor to any of them, so I am afraid I don't know more at this time. |
Beta Was this translation helpful? Give feedback.
-
|
I did some more troubleshooting: The following // index.js
const { spawn } = require('child_process');
// `--verbose` is used to display husky's debugging messages along when your
// `HUSKY_DEBUG` environement variable is set to `true` or `1`.
const p = spawn(
'yarn add husky@^4 --verbose',
[],
{
cwd: process.cwd(),
env: process.env,
stdio: 'inherit',
detached: false,
shell: true // Defaults: yarn = true, npm = false.
// NOTE:
// > If the shell option is enabled, do not pass unsanitized user input to
// > this function. Any input containing shell metacharacters may be used to
// > trigger arbitrary command execution.
}
)
p.on('error', function(err) {
console.log(`child process error:`, err)
})
if (p.stdout) {
p.stdout.on('data', (data) => {
console.log(`stdout data: ${data}`);
});
p.stdout.on('error', (err) => {
console.log(`stdout error: `, err);
});
} else {
// console.log('No stdout')
}
if (p.stderr) {
p.stderr.on('data', (data) => {
console.error(`stderr data: ${data}`);
});
p.stderr.on('error', (err) => {
console.error(`stderr error: `, err);
});
} else {
// console.log('No stderr')
}
p.on('close', (code) => {
if (code != 0) {
console.log(`child process exited with code ${code}`);
}
});then in Windows PowerShell: Not providing
To get closer to what CRA uses, we will switch to cross-spawn ( // index.js
const crossSpawn = require('cross-spawn');
// `--verbose` is used to display husky's debugging messages along when your
// `HUSKY_DEBUG` environement variable is set to `true` or `1`.
const p = crossSpawn.sync(
'yarn', // 'yarnpkg' also works
['add', 'husky@^4', '--verbose'],
{
stdio: 'inherit'
}
)
console.log({p})
// logs =>
// {
// p: {
// status: 0,
// signal: null,
// output: [ null, null, null ],
// pid: /* a number */,
// stdout: null,
// stderr: null,
// error: null
// }
// }We can get the same command working with const cspawn = require('cross-spawn');
// no amount of verbosity will expose the debug messages, at least not with
// npm 7.6.0
const p = cspawn.sync(
'npm',
['install', 'husky@^4'],
{
stdio: 'inherit'
}
)
console.log({p})
// logs =>
// {
// p: {
// status: 0,
// signal: null,
// output: [ null, null, null ],
// pid: /* a number */,
// stdout: null,
// stderr: null,
// error: null
// }
// }The short version is that it looks like the CRA code should work in yarn. It isn't clear why yarn and npm are producing different results. I don't know enough about how yarn's create command works to know if it changes anything. It is also worth pointing out that you are not including |
Beta Was this translation helpful? Give feedback.
-
|
Wow can't thank you enough @npetruzzelli !!!! Just to let you know, I have a different repo for the main |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Hey guys, just hit a rock with custom cra-template and was hoping someone could help (question on StackOverFlow)
I added
husky,lint-stagedandprettierto the official base cra-template. The problem is that thepre-commithook isn't triggered unless I re-add husky.Troubleshooting with
diff, I noticed none of the githooks files are created in.git/hooksdirectory by thecreate-react-appprocess. The files only get created when I re-add husky.git clone https://github.com/piouson/cra-template-husky-test.git npx create-react-app test-app --template file:./cra-template-husky-test ls test-app/.git/hooks # notice only sample files presentEnvironment:
wsl2 Ubuntu 20.04.2 LTS | git v2.25.1 | node v10.23.0 | npm v7.5.6 | yarn v1.22.10Beta Was this translation helpful? Give feedback.
All reactions