From 89568483459c452f92420a5a09072a904fa1292f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1t=C3=A9=20Szab=C3=B3?= Date: Wed, 12 Nov 2025 16:24:47 +0100 Subject: [PATCH] Fix watcher extension Change the extension name so that it's unique, add missing sources to the CMake manifest and update the count of expected extensions. --- hphp/runtime/ext/watcher/config.cmake | 4 +++- hphp/util/hphp-config.h.in | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hphp/runtime/ext/watcher/config.cmake b/hphp/runtime/ext/watcher/config.cmake index 3611da745fbc2d..16cc03cebaafa1 100644 --- a/hphp/runtime/ext/watcher/config.cmake +++ b/hphp/runtime/ext/watcher/config.cmake @@ -1,6 +1,8 @@ -HHVM_DEFINE_EXTENSION("watchman" IMPLICIT +HHVM_DEFINE_EXTENSION("watcher" IMPLICIT SOURCES ext_watcher.cpp + watcher-clock.cpp + watcher-options.cpp SYSTEMLIB ext_watcher.php DEPENDS diff --git a/hphp/util/hphp-config.h.in b/hphp/util/hphp-config.h.in index a63b1cc35f3202..39a7f11d45da2d 100644 --- a/hphp/util/hphp-config.h.in +++ b/hphp/util/hphp-config.h.in @@ -90,7 +90,7 @@ ${HHVM_COMPILES_DEFINE_STRING} #endif #ifdef USE_CMAKE -# if ${HHVM_EXTENSION_COUNT} != 99 +# if ${HHVM_EXTENSION_COUNT} != 100 # error You need to update the config file for the new builtin extension, and add the define to the FB section # endif ${HHVM_EXTENSIONS_ENABLED_DEFINE_STRING}