Add Maestro test for Image.getSize with local drawable resources (#56945)#56945
Closed
Abbondanzo wants to merge 1 commit into
Closed
Add Maestro test for Image.getSize with local drawable resources (#56945)#56945Abbondanzo wants to merge 1 commit into
Image.getSize with local drawable resources (#56945)#56945Abbondanzo wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106089813. |
meta-codesync
Bot
changed the title
Image.getSize with local drawable resourcesImage.getSize with local drawable resources (#56945)
Abbondanzo
force-pushed
the
export-D106089813
branch
from
56db1bd to
1dafe78
Compare
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Jun 3, 2026
…acebook#56945) Summary: Adds a Maestro E2E test that exercises the new RNTester example for `Image.getSize()` with Android drawable resources. The test navigates to the Image examples, opens the "Image.getSize with local drawables" example, taps the run button, and verifies that VectorDrawable and PNG drawable dimensions are returned correctly in dp, and that the error case for a nonexistent drawable shows an error message. Changelog: [Internal] Differential Revision: D106089813
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Jun 3, 2026
…acebook#56945) Summary: Adds a Maestro E2E test that exercises the new RNTester example for `Image.getSize()` with Android drawable resources. The test navigates to the Image examples, opens the "Image.getSize with local drawables" example, taps the run button, and verifies that VectorDrawable and PNG drawable dimensions are returned correctly in dp, and that the error case for a nonexistent drawable shows an error message. Changelog: [Internal] Differential Revision: D106089813
Abbondanzo
force-pushed
the
export-D106089813
branch
from
1dafe78 to
702f17c
Compare
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Jun 3, 2026
…acebook#56945) Summary: Adds a Maestro E2E test that exercises the new RNTester example for `Image.getSize()` with Android drawable resources. The test navigates to the Image examples, opens the "Image.getSize with local drawables" example, taps the run button, and verifies that VectorDrawable and PNG drawable dimensions are returned correctly in dp, and that the error case for a nonexistent drawable shows an error message. Changelog: [Internal] Differential Revision: D106089813
Abbondanzo
force-pushed
the
export-D106089813
branch
from
702f17c to
8b22783
Compare
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Jun 3, 2026
…acebook#56945) Summary: Adds a Maestro E2E test that exercises the new RNTester example for `Image.getSize()` with Android drawable resources. The test navigates to the Image examples, opens the "Image.getSize with local drawables" example, taps the run button, and verifies that VectorDrawable and PNG drawable dimensions are returned correctly in dp, and that the error case for a nonexistent drawable shows an error message. Changelog: [Internal] Differential Revision: D106089813
Abbondanzo
force-pushed
the
export-D106089813
branch
from
8b22783 to
1700abc
Compare
…acebook#56945) Summary: Adds a Maestro E2E test that exercises the new RNTester example for `Image.getSize()` with Android drawable resources. The test navigates to the Image examples, opens the "Image.getSize with local drawables" example, taps the run button, and verifies that VectorDrawable and PNG drawable dimensions are returned correctly in dp, and that the error case for a nonexistent drawable shows an error message. Changelog: [Internal] Reviewed By: javache Differential Revision: D106089813
Abbondanzo
force-pushed
the
export-D106089813
branch
from
1700abc to
b8984b8
Compare
|
This pull request has been merged in 02c5ab7. |
Collaborator
|
This pull request was successfully merged by @Abbondanzo in 02c5ab7 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a Maestro E2E test that exercises the new RNTester example for
Image.getSize()with Android drawable resources. The test navigates to the Image examples, opens the "Image.getSize with local drawables" example, taps the run button, and verifies that VectorDrawable and PNG drawable dimensions are returned correctly in dp, and that the error case for a nonexistent drawable shows an error message.Changelog:
[Internal]
Reviewed By: javache
Differential Revision: D106089813