Fix/unhandled promise rejection stylesheet loading#35415
Closed
Lihexs wants to merge 3 commits intofacebook:mainfrom
Closed
Fix/unhandled promise rejection stylesheet loading#35415Lihexs wants to merge 3 commits intofacebook:mainfrom
Lihexs wants to merge 3 commits intofacebook:mainfrom
Conversation
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
github-actions
Bot
added
the
Resolution: Stale
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix UnhandledPromiseRejection crash in Jest when CSS stylesheet resources fail to load.
When a stylesheet fails to load, the Promise created with
link.onerror = rejectwas not being caught, causing Node.js/Jest to crash with UnhandledPromiseRejection.
Changes:
.catch(() => {})to stylesheet loading Promises inReactFiberConfigDOM.js(3 locations)ReactDOMFloat-test.jsto match actual event dispatch orderNote: The empty
.catch()handler is intentional - React already tracks the error state viastate.loading |= Errored, so the catch is only needed to prevent Node.js from crashing on unhandled rejection.How did you test this change?
Unskipped and ran the previously failing test:
Before fix: Jest crashes with
UnhandledPromiseRejectionAfter fix: Test passes successfully