chore(deps): bump babel core to resolve CI inconsistencies#35440
Closed
RinZ27 wants to merge 1 commit intofacebook:mainfrom
Closed
chore(deps): bump babel core to resolve CI inconsistencies#35440RinZ27 wants to merge 1 commit intofacebook:mainfrom
RinZ27 wants to merge 1 commit intofacebook:mainfrom
Conversation
RinZ27
force-pushed
the
chore/babel-upgrade-optimization
branch
from
2835f5e to
afad836
Compare
RinZ27
force-pushed
the
chore/babel-upgrade-optimization
branch
from
afad836 to
52c8dcf
Compare
Author
|
Ping on this Babel upgrade. It stabilizes some regex-related inconsistencies in the transpilation stage during CI runs. Moving to 7.26 helps avoid some flakiness we've been seeing with the older 7.11 setup. Mind having a look? Thanks! |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
github-actions
Bot
added
the
Resolution: Stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been seeing some weird inconsistencies in our CI runs lately, mostly related to how certain regex patterns are being handled during transpilation. The current Babel 7.11 setup is quite dated and seems to be the bottleneck here.
Updating the core Babel packages to 7.26 seems to stabilize things and silence those annoying warnings. It's high time we moved off these older versions anyway to keep the build pipeline healthy. No changes to the actual React logic, just keeping the house clean.