Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue about locale #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jorgesumle
Copy link

The og:locale says its value should be "The locale these tags are marked up in. Of the format language_TERRITORY. Default is en_US.". But how do I know which identifier use for a language and which identifier use for a territory? Must they have all two characters? I think that this specification should mention ISO 639 as a reference or something similar. Otherwise, it's' impossible to know which values are correct/valid/expected.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@catamphetamine
Copy link

Why are all code samples on the website not highlighted

@jorgesumle
Copy link
Author

Why are all code samples on the website not highlighted

This has nothing to do with this issue. You should open a pull request explaining your issue or fixing it yourself.

@catamphetamine
Copy link

@jorgesumle I wasn't talking to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants