nimble(serde): rename SerializationVersion::kTabletRaw to kTablet (#772)#772
Open
tanjialiang wants to merge 1 commit into
Open
nimble(serde): rename SerializationVersion::kTabletRaw to kTablet (#772)#772tanjialiang wants to merge 1 commit into
tanjialiang wants to merge 1 commit into
Conversation
|
@tanjialiang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106206709. |
tanjialiang
added a commit
to tanjialiang/nimble
that referenced
this pull request
May 24, 2026
…cebookincubator#772) Summary: Renames the `kTabletRaw` serialization format to `kTablet` across the nimble serde stack, plus all related identifiers, comments, and docs. The old `kTabletRaw` name created false symmetry with `kCompactRaw` — both ended in "Raw" but meant very different things: `kCompactRaw` is a regular serialization output using raw-encoded stream sizes, while `kTabletRaw` is a projection-only passthrough format with per-slice headers and chunk metadata preserved. The rename signals "this is structurally different from the other formats" by breaking the parallel — the other names describe an encoding choice (`Legacy`, `Compact`, `CompactRaw`), while `Tablet` describes what the bytes are (passthrough tablet stream content). This is a comment-and-name change only. The wire format byte stays `3` and on-disk/over-the-wire compatibility is preserved. Identifier renames: - `SerializationVersion::kTabletRaw` → `SerializationVersion::kTablet` - `isTabletRawFormat()` → `isTabletFormat()` (both overloads) - `TabletRawChunkStripTest` → `TabletChunkStripTest` (test class) - `serializeTabletRaw()` → `serializeTablet()` (test helper) - `deserializeTabletRaw()` / `deserializeTabletRawWithDCtx()` → `deserializeTablet()` / `deserializeTabletWithDCtx()` (test helpers) - `tabletRawVersionRejected`, `tabletRawDeserialization`, `Serializer_TabletRaw` → `tabletVersionRejected`, `tabletDeserialization`, `Serializer_Tablet` (test names) - `"TabletRawFormat"` test-parameter string → `"TabletFormat"` - `tabletRaw` / `tabletRawInput` / `tabletRawOwned` local variables → `tablet` / `tabletInput` / `tabletOwned` - `"tablet_raw_chunk_test"` memory pool name → `"tablet_chunk_test"` - All comment and doc references to `kTabletRaw` / "tablet raw" updated to `kTablet`. - `Options.cpp::toString()` returns `"kTablet"` to match the new enum name. - `Serializer.cpp` error message updated: "kTablet is not supported by the serializer..." Out of scope: the configerator-side thrift comment at `configerator/structs/datainfra/joiner/sequence_storage_config.thrift:141` ("V3 (tabletRaw):") is an auto-generated mirror and must be updated from the configerator source repo in a separate diff. Reviewed By: xiaoxmeng Differential Revision: D106206709
729d3a5 to
de1b475
Compare
…cebookincubator#772) Summary: Renames the `kTabletRaw` serialization format to `kTablet` across the nimble serde stack, plus all related identifiers, comments, and docs. The old `kTabletRaw` name created false symmetry with `kCompactRaw` — both ended in "Raw" but meant very different things: `kCompactRaw` is a regular serialization output using raw-encoded stream sizes, while `kTabletRaw` is a projection-only passthrough format with per-slice headers and chunk metadata preserved. The rename signals "this is structurally different from the other formats" by breaking the parallel — the other names describe an encoding choice (`Legacy`, `Compact`, `CompactRaw`), while `Tablet` describes what the bytes are (passthrough tablet stream content). This is a comment-and-name change only. The wire format byte stays `3` and on-disk/over-the-wire compatibility is preserved. Identifier renames: - `SerializationVersion::kTabletRaw` → `SerializationVersion::kTablet` - `isTabletRawFormat()` → `isTabletFormat()` (both overloads) - `TabletRawChunkStripTest` → `TabletChunkStripTest` (test class) - `serializeTabletRaw()` → `serializeTablet()` (test helper) - `deserializeTabletRaw()` / `deserializeTabletRawWithDCtx()` → `deserializeTablet()` / `deserializeTabletWithDCtx()` (test helpers) - `tabletRawVersionRejected`, `tabletRawDeserialization`, `Serializer_TabletRaw` → `tabletVersionRejected`, `tabletDeserialization`, `Serializer_Tablet` (test names) - `"TabletRawFormat"` test-parameter string → `"TabletFormat"` - `tabletRaw` / `tabletRawInput` / `tabletRawOwned` local variables → `tablet` / `tabletInput` / `tabletOwned` - `"tablet_raw_chunk_test"` memory pool name → `"tablet_chunk_test"` - All comment and doc references to `kTabletRaw` / "tablet raw" updated to `kTablet`. - `Options.cpp::toString()` returns `"kTablet"` to match the new enum name. - `Serializer.cpp` error message updated: "kTablet is not supported by the serializer..." Out of scope: the configerator-side thrift comment at `configerator/structs/datainfra/joiner/sequence_storage_config.thrift:141` ("V3 (tabletRaw):") is an auto-generated mirror and must be updated from the configerator source repo in a separate diff. Reviewed By: xiaoxmeng Differential Revision: D106206709
de1b475 to
80eb4fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Renames the
kTabletRawserialization format tokTabletacross the nimble serde stack, plus all related identifiers, comments, and docs. The oldkTabletRawname created false symmetry withkCompactRaw— both ended in "Raw" but meant very different things:kCompactRawis a regular serialization output using raw-encoded stream sizes, whilekTabletRawis a projection-only passthrough format with per-slice headers and chunk metadata preserved.The rename signals "this is structurally different from the other formats" by breaking the parallel — the other names describe an encoding choice (
Legacy,Compact,CompactRaw), whileTabletdescribes what the bytes are (passthrough tablet stream content).This is a comment-and-name change only. The wire format byte stays
3and on-disk/over-the-wire compatibility is preserved.Identifier renames:
SerializationVersion::kTabletRaw→SerializationVersion::kTabletisTabletRawFormat()→isTabletFormat()(both overloads)TabletRawChunkStripTest→TabletChunkStripTest(test class)serializeTabletRaw()→serializeTablet()(test helper)deserializeTabletRaw()/deserializeTabletRawWithDCtx()→deserializeTablet()/deserializeTabletWithDCtx()(test helpers)tabletRawVersionRejected,tabletRawDeserialization,Serializer_TabletRaw→tabletVersionRejected,tabletDeserialization,Serializer_Tablet(test names)"TabletRawFormat"test-parameter string →"TabletFormat"tabletRaw/tabletRawInput/tabletRawOwnedlocal variables →tablet/tabletInput/tabletOwned"tablet_raw_chunk_test"memory pool name →"tablet_chunk_test"kTabletRaw/ "tablet raw" updated tokTablet.Options.cpp::toString()returns"kTablet"to match the new enum name.Serializer.cpperror message updated: "kTablet is not supported by the serializer..."Out of scope: the configerator-side thrift comment at
configerator/structs/datainfra/joiner/sequence_storage_config.thrift:141("V3 (tabletRaw):") is an auto-generated mirror and must be updated from the configerator source repo in a separate diff.Reviewed By: xiaoxmeng
Differential Revision: D106206709