Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash probe performance regression with https://github.com/facebookincubator/velox/pull/10652 #11438

Open
JunhyungSong opened this issue Nov 5, 2024 · 3 comments
Open

Hash probe performance regression with https://github.com/facebookincubator/velox/pull/10652 #11438

JunhyungSong opened this issue Nov 5, 2024 · 3 comments
Assignees
@tanjialiang
Labels
bug Something isn't working triage Newly created issue that needs attention.

Comments

@JunhyungSong
Copy link

Bug description

I found that TPC-DS hash probe performance is regressed by ~10% with the PR, #10652.

System information

Spark 3.5 & Gluten 1.2.0

Relevant logs

No response
@JunhyungSong JunhyungSong added bug Something isn't working triage Newly created issue that needs attention. labels Nov 5, 2024
@Yuhta
Copy link
Contributor

Yuhta commented Nov 5, 2024

@tanjialiang Some good candidates to address during code freeze

@FelixYBW
Copy link
Contributor

@JunhyungSong would you like to fix the regression?

@JunhyungSong
Copy link
Author

I have no time now. Will try in December if no one takes this until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanjialiang tanjialiang

Labels
bug Something isn't working triage Newly created issue that needs attention.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Yuhta @tanjialiang @JunhyungSong @FelixYBW