Fix Spark expression fuzzer test on deny_precision_loss functions #11526
+120
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
rui-mo
force-pushed
the
wip_precision_loss
branch
from
cb7e860
to
f726750
Compare
|
cc: @mbasmanova Thanks. |
mbasmanova
reviewed
Nov 14, 2024
|
|
||
| namespace facebook::velox::functions::sparksql::fuzzer { | ||
|
|
||
| class MultiplyDenyPrecisionLossArgGenerator |
There was a problem hiding this comment.
These names are very long. Would it make sense to fold this into MultiplyArgGenerator and add a boolean parameter to the ctor for denyPrecisionLoss?
There was a problem hiding this comment.
Thanks for your review. It makes sense to me. Updated this PR to add an 'allowPrecisionLoss' parameter for each generator.
rui-mo
force-pushed
the
wip_precision_loss
branch
from
f726750
to
2d9c50f
Compare
mbasmanova
approved these changes
Nov 14, 2024
mbasmanova
added
the
ready-to-merge
|
@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 'allowPrecisionLoss' parameter for decimal add/subtract/multiply/divide
argument generators. When false, the generators are used for
deny_precision_loss arithmetic functions.
Fixes: #11522.