Skip to content

Commit 545dd87

Browse files
Zhengjun Xingmeta-codesync[bot]
authored andcommitted
Fix multi-copy benchmark OSError and update libc10.so path (#310)
Summary: This PR includes two fixes: 1. Fix OSError 24 (“Too many open files”) in the multi-copy benchmark by cherry-picking the latest upstream FBGEMM patch. Enables switching to the file_system sharing strategy via: export PYTORCH_SHARE_STRATEGY='file_system'. 2. Fix missing libc10.so caused by a recent path change, which breaks functionality from PR #290. Updates the expected path to the correct library location. Pull Request resolved: #310 Reviewed By: charles-typ Differential Revision: D87577418 Pulled By: YifanYuan3 fbshipit-source-id: 768acca7dcfeba552aa103b125d9ac8cbd1fd68e
1 parent b110f33 commit 545dd87

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

packages/ai_wdl/fbgemm/install_fbgemm_bench.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -906,6 +906,8 @@ clone_fbgemm_repo() {
906906
echo "[SETUP] Cloning repository with submodules..."
907907
git clone --recursive https://github.com/pytorch/FBGEMM.git fbgemm_${FBGEMM_VERSION}
908908
git -C fbgemm_${FBGEMM_VERSION} checkout ${FBGEMM_VERSION}
909+
# Cherry-pick the latest commit from the FBGEMM main branch to fix issue https://github.com/pytorch/FBGEMM/pull/5037
910+
git -C fbgemm_${FBGEMM_VERSION} cherry-pick 9df97a7090c2c5edecea4fd08bad11ab8a23284c
909911

910912
# Disable the postbuild script to prevent race conditions during linking
911913
# This is a workaround for a known issue in the build process
@@ -1129,7 +1131,7 @@ if [[ "$OS_TYPE" == "Linux" && "$ARCH_TYPE" == "aarch64" ]]; then
11291131
if [[ "$BIN" == "tbe_inference_benchmark" ]]; then
11301132
# Resolve repository root based on script location
11311133
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
1132-
REPO_ROOT="$(cd "${SCRIPT_DIR}/../.." && pwd)"
1134+
REPO_ROOT="$(cd "${SCRIPT_DIR}/../../.." && pwd)"
11331135
11341136
# Expected environment name and Python version
11351137
BUILD_ENV="fbgemm_build_oss_env"

0 commit comments

Comments
 (0)