Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Migrate from glmnet_python to sklearn #30

Closed
SarigT opened this issue Feb 1, 2023 · 3 comments
Closed

[FEATURE] Migrate from glmnet_python to sklearn #30

SarigT opened this issue Feb 1, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@SarigT
Copy link
Contributor

SarigT commented Feb 1, 2023

Currently the usage of glmnet_python in ipw fuction is a blocker to:

  1. Using ipw on Windows (due to installation of glment_pyton) (issue: Can't use method = ipw in Windows #26)
  2. Migrating the license from GPL2 to MIT (issue: Migrate license from GPL2 to MIT #16)
  3. Shorter installation (no need to install glmnet)
  4. Compatibility with Scipy 1.9.0+ (issue: Compatibility with Scipy 1.9.0+ bbalasub1/glmnet_python#64)

Current plan is to move from glmnet_python to sklearn during Jan 2025. This issue is to follow on progress.

@SarigT SarigT self-assigned this Feb 1, 2023
@SarigT SarigT added the enhancement New feature or request label Feb 1, 2023
@talgalili
Copy link
Contributor

Two updates:

  1. the current glmnet library seems to not work with Python 3.11. Hence, moving to sklearn will be required in order to keep balance forward compatible with newer versions of python.
  2. Moving to sklearn would enable to to have the ipw also store the model itself, giving the user the ability to use it to predict values for users outside of the sample.
  3. sklearn would also let us move to other models (E.g.: random forest etc.), letting us move beyond glm based LASSO models only.

@talgalili talgalili changed the title Migrate from glmnet_python to sklearn [FEATURE] Migrate from glmnet_python to sklearn Jun 5, 2023
@talgalili
Copy link
Contributor

UPDATE:
This issue is not planned to be addressed during 2023. We'll revisit it in 2024, and hopefully address it then.

@talgalili
Copy link
Contributor

Done here:
8c02b42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants