Skip to content

Migrate the unit tests to insta #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andylokandy opened this issue Mar 14, 2025 · 2 comments
Open

Migrate the unit tests to insta #66

andylokandy opened this issue Mar 14, 2025 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@andylokandy
Copy link
Collaborator

andylokandy commented Mar 14, 2025

fastrace heavily utilizes snapshot tests, and insta is an appealing snapshot tools to improve the experience of managing the snapshot tests.

@andylokandy andylokandy added the help wanted Extra attention is needed label Mar 14, 2025
@andylokandy andylokandy changed the title migrate the unit tests to use insta Migrate the unit tests to insta Mar 14, 2025
@kutal10
Copy link

kutal10 commented Mar 29, 2025

Have taken a look at this, happy to pick up. Have a question though, on top of the crate dependency itself, we have two options here for actually reviewing snapshots:

  1. Have every dev do cargo install cargo-insta and use cargo insta review. Much cleaner, but this introduces a manual dependency on the reviewers' local machine.
  2. We can go down the environment variable route for Insta, but this is going to need devs to manually review the newly generated snapshots.

Have a read, let me know which route we should go down. I'll be documenting this properly, whichever route we go down.

@andylokandy
Copy link
Collaborator Author

I'll be choosing cargo-insta for my development setup since it provides the complete experience of insta. However it is not required if one want to build the lib or run the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants