Handle multiple apps #4
Conversation
| UI.message("Fetching the #{app_identifiers.size} apps, you specified, give me a moment 🤖") | ||
| app_identifiers.each do |app_identifier| | ||
| app = Spaceship::Application.find(app_identifier) | ||
| unless app |
There was a problem hiding this comment.
Could this be more Ruby like or is it good enough?
| @@ -45,12 +63,12 @@ def self.run(params) | |||
| end | |||
| end | |||
|
|
|||
| def self.remove_tester(tester, app_id, dry_run) | |||
| def self.remove_tester(tester, app, dry_run) | |||
There was a problem hiding this comment.
I hardly remember ids, so lets pass app object and show app name when printing and use apple_id when deleting.
|
|
||
| all_testers = Spaceship::TestFlight::Tester.all(app_id: app_id) | ||
| counter = 0 |
There was a problem hiding this comment.
We went from mere 4 testers being removed on our most popular test app
To now 164 when rolling over all apps 👍
Only took 27 seconds to go through 🤖 . Yet for a human.... 😱
|
@KrauseFx when you have time 👍 It's been pretty solid for house cleaning. |
|
@KrauseFx will the PR be open for merging after I fix conflict or should I not even bother 👎 We definitely been using this feature for our use case. |
|
Hey @Casz, sorry for the late reply, thanks for your PR 👍 Quick question: as a workaround, can users just call the plugin multiple times for each app, right? |
|
Yes, they could, but why not give them the power 👍 Here we gave them 3 options. |
|
@KrauseFx I'll try and rebase and hope you will pick this up! Hate to see this go to waste |
* Fetch all apps if no identifier specified. * Handle multiple identifiers
|
@KrauseFx rebased |
|
@KrauseFx travis is very different from circle CI now it seems 😢 |
fixes #3