Skip to content

Commit 1b72f60

Browse files
committed
Improve logging for INVERTER_MAX_TARGET_SOC
1 parent 5079579 commit 1b72f60

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

source/inverter_charge_controller.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -149,9 +149,7 @@ def _do_iteration(self) -> tuple[datetime, bool]: # FIXME: Find better name
149149
current_energy_in_battery = self.inverter.calculate_energy_saved_in_battery_from_state_of_charge(
150150
current_state_of_charge
151151
)
152-
self.log.info(
153-
f"The battery is currently at {current_state_of_charge} %, thus it is holding {current_energy_in_battery}"
154-
)
152+
self.log.info(f"The battery is currently holds {current_energy_in_battery} ({current_state_of_charge} %)")
155153

156154
target_min_state_of_charge = int(EnvironmentVariableGetter.get("INVERTER_TARGET_MIN_STATE_OF_CHARGE", 20))
157155
energy_to_be_in_battery_when_reaching_next_minimum = (
@@ -195,10 +193,12 @@ def _do_iteration(self) -> tuple[datetime, bool]: # FIXME: Find better name
195193
f"Need to charge to {required_state_of_charge} % in order to reach the next minimum with {target_min_state_of_charge} % left"
196194
)
197195

198-
max_target_soc = int(EnvironmentVariableGetter.get("INVERTER_MAX_TARGET_SOC", 90))
196+
max_target_soc_environment_variable = "INVERTER_MAX_TARGET_SOC"
197+
max_target_soc = int(EnvironmentVariableGetter.get(max_target_soc_environment_variable, 90))
199198
if required_state_of_charge > max_target_soc:
200199
self.log.info(
201-
f"The target state of charge is (nearly) 100 %. Setting it to {max_target_soc} since charging the battery this full takes hours for the last few percent."
200+
"The target state of charge is more than the maximum allowed charge set in the environment "
201+
+ f'("{max_target_soc_environment_variable}") --> Setting it to {max_target_soc}'
202202
)
203203
required_state_of_charge = max_target_soc
204204

@@ -282,7 +282,7 @@ def _charge_inverter(self, target_state_of_charge: int) -> None:
282282

283283
if current_state_of_charge >= target_state_of_charge:
284284
self.log.info(
285-
f"Charging finished {current_state_of_charge} % --> Setting the inverter back to normal mode"
285+
f"Charging finished ({current_state_of_charge} %) --> Setting the inverter back to normal mode"
286286
)
287287
self.inverter.set_operation_mode(OperationMode.GENERAL)
288288
break

0 commit comments

Comments
 (0)