Skip to content

Conversation

@serialx
Copy link

@serialx serialx commented Jul 25, 2025

Summary

  • Added optional 'wait' parameter to write_to_terminal tool (defaults to true)
  • Enables testing of TUI applications that don't exit automatically
  • Allows interaction with long-running terminal applications

Test plan

  • Test with TUI applications that require user interaction
  • Ensure terminal control is properly returned after wait period

serialx added 2 commits July 25, 2025 13:47
- Added optional 'wait' parameter to write_to_terminal tool
- Enables testing of TUI applications that don't exit automatically
- Allows interaction with long-running terminal applications
@ferrislucas
Copy link
Owner

Hi @serialx thanks so much for contributing! I had some trouble running the e2e tests (yarn e2e) against your PR. I was able to fix the issue by giving the executeCommand method in the CommandExecutor class a default wait value of true. After I did that, the tests ran successfully.

I want to better understand your use case here. Can I ask what you're seeing that prompted you to add this parameter? I'm not at all suggesting that it's unnecessary - I just want to understand a little more about the problem that you're solving. I've used iterm-mcp for some TUI apps, and I haven't had any issues. I'm totally not suggesting that your PR doesn't solve a problem. I just want to understand more.

Thanks again for contributing, and I apologize for the delayed response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants