Skip to content

Improve heartbeat argument handling in the FDC3 for Web reference implementation demo #1678

Description

@kriswest

To disable heartbeats in the reference implementation demo, you need to modify this line:

const fdc3Server = new DefaultFDC3Server(sc, directory, channelDetails, true, 20000, 10017);

(set the 4th argument to the DefaultFDC3Server constructor to false).

Its looks like the DefaultFDC3Server parameters for heartbeats:

constructor(
sc: ServerContext<AppRegistration>,
directory: Directory,
userChannels: ChannelState[],
heartbeats: boolean,
intentTimeoutMs: number = 20000,
openHandlerTimeoutMs: number = 10000
) {

could do with some work as they don't match those for the HeartbeatHandler, which you actually want to control:
constructor(pingInterval: number = 1000, disconnectedAfter: number = 5000, deadAfter: number = 20000) {

The OpenHandlerTimeout has nothing to do with heartbeats and should not be being used to set the heartbeat times - we should have a different argument for this in the DefaultFDC3Server contructor!

Originally posted by @kriswest in #1675 (reply in thread)

Metadata

Metadata

Assignees

No one assigned

    Labels

    FDC3 for Web Browsersfdc3-web-implImplementation of FDC3 Desktop Agent in toolbox/fdc3-for-web/fdc3-web-implhelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions