Merge pull request #1262 from jescalada/plugin-loader-test-fixes

fix: Plugin loader tests

Author: jescalada

package-lock.json

@@ -29,6 +29,11 @@
       "import": "./dist/src/types/models.js",
       "require": "./dist/src/types/models.js",
       "types": "./dist/src/types/models.d.ts"
+    },
+    "./plugin": {
+      "import": "./dist/src/plugin.js",
+      "require": "./dist/src/plugin.js",
+      "types": "./dist/src/plugin.d.ts"
     }
   },
   "scripts": {

package.json

@@ -22,42 +22,34 @@ describe('loading plugins from packages', function () {
     spawnSync('npm', ['install'], { cwd: testPackagePath, timeout: 5000 });
   });
 
-  it.skip(
-    'should load plugins that are the default export (module.exports = pluginObj)',
-    async function () {
-      const loader = new PluginLoader([join(testPackagePath, 'default-export.js')]);
-      await loader.load();
-      expect(loader.pushPlugins.length).to.equal(1);
-      expect(loader.pushPlugins.every((p) => isCompatiblePlugin(p))).to.be.true;
-      expect(loader.pushPlugins[0]).to.be.an.instanceOf(PushActionPlugin);
-    },
-  ).timeout(10000);
+  it('should load plugins that are the default export (module.exports = pluginObj)', async function () {
+    const loader = new PluginLoader([join(testPackagePath, 'default-export.js')]);
+    await loader.load();
+    expect(loader.pushPlugins.length).to.equal(1);
+    expect(loader.pushPlugins.every((p) => isCompatiblePlugin(p))).to.be.true;
+    expect(loader.pushPlugins.every((p) => isCompatiblePlugin(p, 'isGitProxyPushActionPlugin'))).to
+      .be.true;
+  }).timeout(10000);
 
-  it.skip(
-    'should load multiple plugins from a module that match the plugin class (module.exports = { pluginFoo, pluginBar })',
-    async function () {
-      const loader = new PluginLoader([join(testPackagePath, 'multiple-export.js')]);
-      await loader.load();
-      expect(loader.pushPlugins.length).to.equal(1);
-      expect(loader.pullPlugins.length).to.equal(1);
-      expect(loader.pushPlugins.every((p) => isCompatiblePlugin(p))).to.be.true;
-      expect(loader.pushPlugins.every((p) => isCompatiblePlugin(p, 'isGitProxyPushActionPlugin')))
-        .to.be.true;
-      expect(loader.pullPlugins.every((p) => isCompatiblePlugin(p, 'isGitProxyPullActionPlugin')))
-        .to.be.true;
-      expect(loader.pushPlugins[0]).to.be.instanceOf(PushActionPlugin);
-      expect(loader.pullPlugins[0]).to.be.instanceOf(PullActionPlugin);
-    },
-  ).timeout(10000);
+  it('should load multiple plugins from a module that match the plugin class (module.exports = { pluginFoo, pluginBar })', async function () {
+    const loader = new PluginLoader([join(testPackagePath, 'multiple-export.js')]);
+    await loader.load();
+    expect(loader.pushPlugins.length).to.equal(1);
+    expect(loader.pullPlugins.length).to.equal(1);
+    expect(loader.pushPlugins.every((p) => isCompatiblePlugin(p))).to.be.true;
+    expect(loader.pushPlugins.every((p) => isCompatiblePlugin(p, 'isGitProxyPushActionPlugin'))).to
+      .be.true;
+    expect(loader.pullPlugins.every((p) => isCompatiblePlugin(p, 'isGitProxyPullActionPlugin'))).to
+      .be.true;
+  }).timeout(10000);
 
-  it.skip('should load plugins that are subclassed from plugin classes', async function () {
+  it('should load plugins that are subclassed from plugin classes', async function () {
     const loader = new PluginLoader([join(testPackagePath, 'subclass.js')]);
     await loader.load();
     expect(loader.pushPlugins.length).to.equal(1);
     expect(loader.pushPlugins.every((p) => isCompatiblePlugin(p))).to.be.true;
     expect(loader.pushPlugins.every((p) => isCompatiblePlugin(p, 'isGitProxyPushActionPlugin'))).to
       .be.true;
-    expect(loader.pushPlugins[0]).to.be.instanceOf(PushActionPlugin);
   }).timeout(10000);
 
   it('should not load plugins that are not valid modules', async function () {