Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
149 commits
Select commit Hold shift + click to select a range
d3d73d9
refactor(ts): passport/activeDirectory
jescalada Aug 24, 2025
ba086f1
chore: add missing types
jescalada Aug 24, 2025
0c7d1fb
refactor(ts): JWT handler and utils
jescalada Aug 24, 2025
b419f4e
refactor(ts): passport/index
jescalada Aug 24, 2025
06a64ea
refactor(ts): passport/local
jescalada Aug 24, 2025
4dfbc2d
refactor(ts): passport/ldaphelper
jescalada Aug 24, 2025
09a1876
refactor(ts): passport/oidc
jescalada Aug 24, 2025
abc09bd
refactor(ts): auth routes
jescalada Aug 24, 2025
03c4952
refactor(ts): config routes
jescalada Aug 24, 2025
7ed9eb0
refactor(ts): misc routes and index
jescalada Aug 24, 2025
3d99de2
refactor(ts): push routes and update related types/db handlers
jescalada Aug 24, 2025
944e0b5
refactor(ts): repo routes
jescalada Aug 24, 2025
6a7089f
refactor(ts): user routes
jescalada Aug 24, 2025
6c9d3bf
refactor(ts): emailSender and missing implementation
jescalada Aug 24, 2025
6899e4e
refactor(ts): service/index and missing types
jescalada Aug 24, 2025
63c30a0
refactor(ts): urls
jescalada Aug 24, 2025
812a910
fix: failing tests due to incorrect imports
jescalada Aug 27, 2025
9d5bdd8
chore: update .eslintrc
jescalada Aug 27, 2025
c951015
chore: fix type checks
jescalada Aug 27, 2025
b046903
chore: fix CLI service imports
jescalada Aug 27, 2025
97ad7c7
Merge branch 'main' of https://github.com/finos/git-proxy into servic…
jescalada Aug 28, 2025
9008ac5
chore: run npm format
jescalada Aug 28, 2025
f36b3d1
test: add basic oidc tests and ignore openid-client type error on import
jescalada Aug 28, 2025
51df315
test: increase testOidc and testPush coverage
jescalada Aug 28, 2025
f7ed291
test: improve push test coverage
jescalada Aug 28, 2025
b2b1b14
test: add missing smtp tests
jescalada Aug 28, 2025
ae43800
Update .eslintrc.json
jescalada Aug 29, 2025
17a8adf
Update src/db/file/users.ts
jescalada Aug 29, 2025
c7cf87e
Update src/service/passport/jwtAuthHandler.ts
jescalada Aug 29, 2025
8aa1a97
Update src/service/passport/index.ts
jescalada Aug 29, 2025
962a0ba
chore: fix service/index proxy type and npm run format
jescalada Aug 29, 2025
7eda433
Update src/service/passport/jwtAuthHandler.ts
jescalada Aug 29, 2025
df80fef
Update src/service/passport/jwtUtils.ts
jescalada Aug 29, 2025
095ae62
chore: add getSessionStore helper for fs sink and fix types
jescalada Aug 29, 2025
b094ff1
Merge branch 'service-ts-refactor-redone' of https://github.com/jesca…
jescalada Aug 29, 2025
f9cea8c
chore: remove unnecessary casting for JWT verifiedPayload
jescalada Aug 29, 2025
ee63f9c
chore: update getSessionStore call
jescalada Aug 29, 2025
0dc78ce
chore: replace unused UserInfoResponse with imported version
jescalada Aug 29, 2025
2429fbe
chore: improve userEmail checks on push routes
jescalada Aug 29, 2025
a368642
chore: update packages
jescalada Aug 29, 2025
8971566
Merge branch 'main' into service-ts-refactor-redone
jescalada Aug 29, 2025
6c427b9
chore: add typing for thirdPartyApiConfig
jescalada Sep 3, 2025
5805dd9
chore: fix AD passport types
jescalada Sep 3, 2025
bec32f7
chore: replace AD type with activedirectory2
jescalada Sep 4, 2025
573cc92
chore: improve loginSuccessHandler
jescalada Sep 4, 2025
a211560
chore: fix PushQuery typing
jescalada Sep 4, 2025
e299e85
chore: fix "any" in repo and users routes and fix failing tests
jescalada Sep 4, 2025
3dd1bd0
refactor: flatten push routes and fix typings
jescalada Sep 4, 2025
8e6d1d3
chore: add isAdminUser check to repo routes
jescalada Sep 4, 2025
db60fbf
test: improve push test checks for cancel endpoint
jescalada Sep 4, 2025
dfb1e04
Merge branch 'main' into service-ts-refactor-redone
jescalada Sep 4, 2025
95495f2
chore: fix createDefaultAdmin and isAdminUser functions
jescalada Sep 4, 2025
3469b54
chore: fix thirdPartyApiConfig and AD type errors
jescalada Sep 4, 2025
cd68915
chore: remove nodemailer and unused functionality
jescalada Sep 4, 2025
728b5aa
chore: fix failing CLI test (email not unique)
jescalada Sep 4, 2025
4d3d083
chore: remove unused smtp config variables
jescalada Sep 4, 2025
0343438
Update src/service/routes/publicApi.ts
jescalada Sep 5, 2025
0109b0b
chore: fix toPublicUser calls and typing
jescalada Sep 5, 2025
052a00e
Merge branch 'main' into service-ts-refactor-redone
jescalada Sep 10, 2025
3a66ca4
chore: update sample test src/service import
jescalada Sep 10, 2025
e321a3a
chore: fix inline imports for vitest execution
jescalada Sep 14, 2025
18994f5
refactor(vite): prepare vite dependencies
jescalada Sep 14, 2025
f572fa8
refactor(vite): sample test file to TS and vite, update comments
jescalada Sep 14, 2025
5f10eb2
refactor(vite): checkHiddenCommit tests
jescalada Sep 14, 2025
7f15848
fix: add vitest config and fix flaky tests
jescalada Sep 14, 2025
7ca70a5
refactor(vite): chain tests
jescalada Sep 15, 2025
8ccb420
Merge branch 'main' into 1150-vitest-migration-from-service
jescalada Sep 15, 2025
177889c
chore: remove unused vite dep
jescalada Sep 15, 2025
b42350b
fix: add missing auth attributes to config.schema.json
jescalada Sep 15, 2025
29ad29b
fix: add missing types and fix TS errors
jescalada Sep 15, 2025
ee1cfae
refactor(vitest): ConfigLoader tests and fix type errors
jescalada Sep 18, 2025
445b5de
refactor(vitest): db-helper tests
jescalada Sep 19, 2025
3e57988
refactor(vitest): generated-config tests
jescalada Sep 19, 2025
0c322b6
refactor(vitest): proxy tests and add lazy loading for server options
jescalada Sep 20, 2025
2a2c476
refactor(vitest): proxyURL
jescalada Sep 20, 2025
c60aee4
refactor(vitest): teeAndValidation
jescalada Sep 20, 2025
762d4b1
refactor(vitest): activeDirectoryAuth
jescalada Sep 20, 2025
e706f5f
refactor(vitest): authMethods and checkUserPushPermissions
jescalada Sep 20, 2025
4fe3fd6
refactor(vitest): config
jescalada Sep 21, 2025
9918720
refactor(vitest): db tests and fix type mismatches
jescalada Sep 21, 2025
b5243cc
refactor(vitest): jwtAuthHandler tests
jescalada Sep 21, 2025
339d30d
refactor(vitest): login tests
jescalada Sep 22, 2025
b9d0a97
chore: add vitest script to package.json
jescalada Sep 22, 2025
f871eec
refactor(vitest): src/service/passport/oidc
jescalada Sep 26, 2025
0526f59
refactor(vitest): testParseAction
jescalada Sep 27, 2025
d30f6ad
Merge branch 'main' into 1150-vitest-migration-from-service
jescalada Sep 28, 2025
6d5bc20
fix: unused/invalid tests and refactor extractRawBody tests
jescalada Sep 28, 2025
022afd4
refactor(vitest): testParsePush tests and linting
jescalada Sep 28, 2025
ee0ee7e
Merge branch 'main' into 1150-vitest-migration-from-service
jescalada Sep 28, 2025
73b43d6
fix: users endpoint merge conflict
jescalada Sep 28, 2025
9ea3fd4
refactor(vitest): rewrite proxy tests in Vitest + TS
jescalada Sep 30, 2025
b435c1e
Merge branch 'main' into 1150-vitest-migration-from-service
jescalada Oct 1, 2025
710d705
refactor(vitest): testProxyRoute tests
jescalada Oct 1, 2025
43a2bb7
refactor(vitest): push tests
jescalada Oct 2, 2025
0776568
refactor(vitest): testRepoApi tests
jescalada Oct 2, 2025
a82c7f4
refactor(vitest): testRouteFilter tests
jescalada Oct 2, 2025
5aaceb1
refactor(vitest): forcePush integration test
jescalada Oct 2, 2025
717d5d6
refactor(vitest): plugin tests
jescalada Oct 5, 2025
6c81ec3
refactor(vitest): prereceive hook tests
jescalada Oct 5, 2025
5e1064a
refactor(vitest): rewrite tests for blockForAuth
jescalada Oct 5, 2025
a5dc971
refactor(vitest): rewrite checkAuthorEmails tests
jescalada Oct 5, 2025
792acc0
chore: add fuzzing and fix lint/type errors
jescalada Oct 5, 2025
194e0bc
refactor(vitest): rewrite checkCommitMessages tests
jescalada Oct 5, 2025
cc23768
fix: uncaught error on invalid regex in checkCommitMessages, type fix
jescalada Oct 5, 2025
3e6e9aa
chore: update vitest script
jescalada Oct 6, 2025
b11cc92
refactor(vitest): checkEmptyBranch tests
jescalada Oct 7, 2025
8cbac2b
refactor(vitest): checkIfWaitingAuth tests
jescalada Oct 7, 2025
fdf1c47
refactor(vitest): checkUserPushPermission tests
jescalada Oct 7, 2025
1f82d8f
refactor(vitest): clearBareClone tests
jescalada Oct 7, 2025
c0e416b
refactor(vitest): getDiff tests
jescalada Oct 8, 2025
aa93e14
refactor(vitest): gitLeaks tests
jescalada Oct 8, 2025
e10b33f
refactor(vitest): scanDiff emptyDiff tests
jescalada Oct 8, 2025
fdb064d
refactor(vitest): scanDiff tests
jescalada Oct 8, 2025
86759ff
refactor(vitest): testCheckRepoInAuthList tests
jescalada Oct 8, 2025
46ab992
refactor(vitest): writePack tests
jescalada Oct 8, 2025
b5f0fb1
refactor(vitest): auth tests
jescalada Oct 8, 2025
6b9bf65
refactor(vitest): file repo tests
jescalada Oct 8, 2025
e570dbf
refactor(vitest): mongo repo tests
jescalada Oct 8, 2025
3bcddb8
refactor(vitest): user routes tests
jescalada Oct 10, 2025
88f992d
refactor(vitest): apiBase tests
jescalada Oct 10, 2025
173028e
refactor(vitest): db tests
jescalada Oct 10, 2025
7a198e3
chore: replace old test and coverage scripts
jescalada Oct 10, 2025
c4a4423
Merge branch 'main' into 1150-vitest-migration-from-service
jescalada Oct 10, 2025
33117d0
Merge branch 'main' into 1150-vitest-migration-from-service
jescalada Oct 10, 2025
f7be67c
chore: remove unused test deps and update depcheck script
jescalada Oct 10, 2025
c85bb34
Merge branch '1150-vitest-migration-from-service' of https://github.c…
jescalada Oct 10, 2025
b5746d0
fix: reset modules in testProxyRoute and add/replace types for app
jescalada Oct 11, 2025
a20d39a
fix: CI test script and unused deps
jescalada Oct 11, 2025
fb903c3
fix: add proper cleanup to proxy tests
jescalada Oct 11, 2025
73e5d8b
chore: temporarily skip proxy tests to prevent errors
jescalada Oct 11, 2025
f1920c9
chore: temporarily skip problematic proxy route tests
jescalada Oct 11, 2025
5f4ac95
chore: temporarily add ts-mocha to CLI dev deps
jescalada Oct 13, 2025
52cfaab
chore: update vitest config to limit coverage check to API
jescalada Oct 13, 2025
c9b324a
chore: exclude more unnecessary files in coverage and include only TS…
jescalada Oct 13, 2025
a268711
chore: exclude type files from coverage check
jescalada Oct 13, 2025
41abea2
test: rewrite proxy filter tests and new ones for helpers
jescalada Oct 14, 2025
65aa650
chore: bump vite to latest
jescalada Oct 14, 2025
4909c03
Merge branch 'main' into 1150-vitest-migration-from-service
jescalada Oct 22, 2025
51478b0
chore: update package-lock.json and remove unused JS test
jescalada Oct 22, 2025
bfa4374
fix: failing tests and formatting
jescalada Oct 22, 2025
b375597
Merge branch 'main' into 1150-vitest-migration-from-service
jescalada Oct 22, 2025
c3995c5
chore: add BlueOak-1.0.0 to allowed licenses list
jescalada Oct 27, 2025
4b1adbc
Merge branch 'main' into 1150-vitest-migration-from-service
jescalada Oct 27, 2025
ef6b730
Merge branch 'main' into 1150-vitest-migration-from-service
jescalada Oct 27, 2025
2350b59
Merge branch 'main' into 1150-vitest-migration-from-service
jescalada Oct 30, 2025
9951967
Merge branch 'main' into 1150-vitest-migration-from-service
jescalada Nov 3, 2025
8e38584
Merge branch 'main' into 1150-vitest-migration-from-service
jescalada Nov 5, 2025
ea1f875
Merge branch 'main' into 1150-vitest-migration-from-service
jescalada Nov 7, 2025
1a42226
Merge branch 'main' into 1150-vitest-migration-from-service
jescalada Nov 7, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dependency-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ jobs:
with:
comment-summary-in-pr: always
fail-on-severity: high
allow-licenses: MIT, MIT-0, Apache-2.0, BSD-3-Clause, BSD-3-Clause-Clear, ISC, BSD-2-Clause, Unlicense, CC0-1.0, 0BSD, X11, MPL-2.0, MPL-1.0, MPL-1.1, MPL-2.0, OFL-1.1, Zlib
allow-licenses: MIT, MIT-0, Apache-2.0, BSD-3-Clause, BSD-3-Clause-Clear, ISC, BSD-2-Clause, Unlicense, CC0-1.0, 0BSD, X11, MPL-2.0, MPL-1.0, MPL-1.1, MPL-2.0, OFL-1.1, Zlib, BlueOak-1.0.0
fail-on-scopes: development, runtime
allow-dependencies-licenses: 'pkg:npm/caniuse-lite'
2 changes: 1 addition & 1 deletion .github/workflows/unused-dependencies.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
node-version: '22.x'
- name: 'Run depcheck'
run: |
npx depcheck --skip-missing --ignores="tsx,@babel/*,@commitlint/*,eslint,eslint-*,husky,mocha,ts-mocha,ts-node,concurrently,nyc,prettier,typescript,tsconfig-paths,vite-tsconfig-paths,@types/sinon,quicktype,history,@types/domutils"
npx depcheck --skip-missing --ignores="tsx,@babel/*,@commitlint/*,eslint,eslint-*,husky,ts-node,concurrently,nyc,prettier,typescript,tsconfig-paths,vite-tsconfig-paths,quicktype,history,@types/domutils,@vitest/coverage-v8"
echo $?
if [[ $? == 1 ]]; then
echo "Unused dependencies or devDependencies found"
Expand Down
16 changes: 15 additions & 1 deletion config.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,10 @@
"password": {
"type": "string",
"description": "Password for the given `username`."
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to run the schema docs generator (gen-schema-doc) to add these properties to the config reference? Give me a shout if not (i.e. if you haven't got the python env setup needed to do so).

You have run the quicktype generator (generate-config-types).

"searchBase": {
"type": "string",
"description": "Override baseDN to query for users in other OUs or sub-trees."
}
},
"required": ["url", "baseDN", "username", "password"]
Expand Down Expand Up @@ -466,7 +470,9 @@
"description": "Additional JWT configuration.",
"properties": {
"clientID": { "type": "string" },
"authorityURL": { "type": "string" }
"authorityURL": { "type": "string" },
"expectedAudience": { "type": "string" },
"roleMapping": { "$ref": "#/definitions/roleMapping" }
},
"required": ["clientID", "authorityURL"]
}
Expand All @@ -482,6 +488,14 @@
"adminOnly": { "type": "boolean" },
"loginRequired": { "type": "boolean" }
}
},
"roleMapping": {
"type": "object",
"description": "Mapping of application roles to JWT claims. Each key is a role name, and its value is an object mapping claim names to expected values.",
"additionalProperties": {
"type": "object",
"additionalProperties": { "type": "string" }
}
}
},
"additionalProperties": false
Expand Down
1 change: 1 addition & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ export default defineConfig(
],
// allow for chai `expect().to.xyz`
'@typescript-eslint/no-unused-expressions': 'off',
'new-cap': ['error', { capIsNewExceptionPattern: '^express\\..*' }],
},
},

Expand Down
Loading
Loading