feat(firestore): Added Firestore Multi Database Support #733
Conversation
Summary of ChangesHello @jonathanedey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Firestore client by introducing support for multiple named databases. It provides a new API method, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for multiple Cloud Firestore databases by adding a new FirestoreWithDatabase function. The implementation is accompanied by comprehensive unit and integration tests. My feedback focuses on improving code maintainability by addressing code duplication and enhancing the robustness of the integration tests to ensure proper resource cleanup.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for multiple named databases in Cloud Firestore by adding a FirestoreWithDatabase method. The implementation maintains backward compatibility by having the existing Firestore method call the new one with the default database ID. The changes are well-tested with new unit and integration tests. My review includes a couple of suggestions for the new integration tests to improve maintainability and adhere to Go's testing best practices.
lahirumaramba
left a comment
lahirumaramba
left a comment
There was a problem hiding this comment.
Thank you! Added a few comments.
|
|
||
| // This test requires a non-default database to exist in the project. | ||
| // If it doesn't exist, this test will fail. | ||
| client, err := app.FirestoreWithDatabaseID(ctx, "testing-database") |
There was a problem hiding this comment.
Let's make testing-database a const (instead of a string here) and add a note to CONTRIBUTING.md to help setup integration test projects in the future.
| // If it doesn't exist, this test will fail. | ||
| client, err := app.FirestoreWithDatabaseID(ctx, "testing-database") | ||
| if err != nil { | ||
| t.Fatal(err) |
There was a problem hiding this comment.
Let's add a log here explaining the custom database might not exists in the integration project. Helps with debugging if you are setting up the workflow for the first time.
| } | ||
| } | ||
|
|
||
| func TestFirestoreMultiDB(t *testing.T) { |
There was a problem hiding this comment.
This feels repetitive. Doesn't TestFirestoreWithDatabaseID and TestFirestore cover this?
| } | ||
| } | ||
|
|
||
| func TestServerTimestamp(t *testing.T) { |
There was a problem hiding this comment.
Why do we need a separate test to check the server timestamp?
2 participants
RELEASE NOTE: Added support for multiple Cloud Firestore named databases.