Skip to content

Commit f45ab51

Browse files
authored
Removed skrinkwrap File (#124)
* Removed shrinkwrap file * Updated version in package lock
1 parent 314b0a4 commit f45ab51

File tree

4 files changed

+68
-69
lines changed

4 files changed

+68
-69
lines changed

CONTRIBUTING.md

+1
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,7 @@ Here are some highlights of the directory structure and notable source files
185185
* `verifyReleaseTarball.sh` - Installs and validates the release tarballs created by
186186
`createReleaseTarball.sh`.
187187
* `gulpfile.js` - Defines the `gulp` tasks necessary for building release artifacts.
188+
* `package-lock.json` - A snapshot of the dependency tree for development and CI purposes.
188189
* `tslint.json` - TypeScript linting rules.
189190
* `tsconfig.json` - TypeScript configuration options.
190191
* `tsconfig-lint.json` - TypeScript configuration options for the linter. This simply widens

createReleaseTarball.sh

+7-15
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,13 @@ sed -i '' -e s/"\"version\": \".*\""/"\"version\": \"${VERSION_WITHOUT_RC}\""/ p
8989
echo
9090

9191

92-
####################################
93-
# REGENERATE npm-shrinkwrap.json #
94-
####################################
95-
echo "[INFO] Removing lib/, node_modules/, and npm-shrinkwrap..."
96-
rm -rf lib/ node_modules/ npm-shrinkwrap.json
92+
############################
93+
# REINSTALL DEPENDENCIES #
94+
############################
95+
echo "[INFO] Removing lib/, and node_modules/..."
96+
rm -rf lib/ node_modules/
9797
if [[ $? -ne 0 ]]; then
98-
echo "Error: Failed to remove lib/, node_modules/, and npm-shrinkwrap."
98+
echo "Error: Failed to remove lib/, and node_modules/."
9999
exit 1
100100
fi
101101
echo
@@ -108,14 +108,6 @@ if [[ $? -ne 0 ]]; then
108108
fi
109109
echo
110110

111-
echo "[INFO] Regenerating npm-shrinkwrap.json file..."
112-
npm shrinkwrap
113-
if [[ $? -ne 0 ]]; then
114-
echo "Error: Failed to regenerate npm-shrinkwrap.json file."
115-
exit 1
116-
fi
117-
echo
118-
119111

120112
############################
121113
# CREATE RELEASE TARBALL #
@@ -190,5 +182,5 @@ echo
190182
##############
191183

192184
echo "[INFO] firebase-admin-${VERSION}.tgz successfully created!"
193-
echo "[INFO] Create a CL for the updated package.json and npm-shrinkwrap.json if this is an actual release."
185+
echo "[INFO] Create a CL for the updated package.json if this is an actual release."
194186
echo

npm-shrinkwrap.json renamed to package-lock.json

+59-52
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@
4343
"lib/",
4444
"LICENSE",
4545
"README.md",
46-
"package.json",
47-
"npm-shrinkwrap.json"
46+
"package.json"
4847
],
4948
"types": "./lib/index.d.ts",
5049
"dependencies": {

0 commit comments

Comments
 (0)