Skip to content

Commit 1ecf690

Browse files
authored
Add FieldValue.boolean_value() (#862)
1 parent 3e7c062 commit 1ecf690

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

Firestore/core/src/firebase/firestore/model/field_value.h

+5
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,11 @@ class FieldValue {
9696
return tag_;
9797
}
9898

99+
bool boolean_value() const {
100+
FIREBASE_ASSERT(tag_ == Type::Boolean);
101+
return boolean_value_;
102+
}
103+
99104
int64_t integer_value() const {
100105
FIREBASE_ASSERT(tag_ == Type::Integer);
101106
return integer_value_;

Firestore/core/src/firebase/firestore/remote/serializer.cc

+1-6
Original file line numberDiff line numberDiff line change
@@ -131,12 +131,7 @@ void Serializer::EncodeFieldValue(const FieldValue& field_value,
131131
// TODO(rsgowman): figure out error handling
132132
abort();
133133
}
134-
if (field_value == FieldValue::TrueValue()) {
135-
EncodeBool(&stream, true);
136-
} else {
137-
FIREBASE_DEV_ASSERT(field_value == FieldValue::FalseValue());
138-
EncodeBool(&stream, false);
139-
}
134+
EncodeBool(&stream, field_value.boolean_value());
140135
break;
141136

142137
case FieldValue::Type::Integer:

0 commit comments

Comments
 (0)