Skip to content

Commit d03362a

Browse files
authored
Firestore: pin googletest to a commit that supports c++14 in cmake builds (#14474)
1 parent bbd9fb3 commit d03362a

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

cmake/external/googletest.cmake

+6-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,12 @@ endif()
2020

2121
# Note: googletest lives at head and encourages to just point to a head commit.
2222
# https://github.com/google/googletest/blob/bf66935e07/README.md?plain=1#L5-L10
23-
set(version main)
23+
24+
# Commit 4a00a24fff was chosen because it is the _last_ commit before googletest
25+
# dropped c++14 support, setting the floor to c++17. Once Firebase sets _its_
26+
# floor to c++17, this pinned commit can be moved to a new one.
27+
# See https://github.com/firebase/firebase-ios-sdk/pull/14474.
28+
set(version 4a00a24fff)
2429

2530
ExternalProject_Add(
2631
googletest

0 commit comments

Comments
 (0)