Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Firestore/core/src/api/expressions.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class Expr {

class Selectable : public Expr {
public:
virtual ~Selectable() override = default;
~Selectable() override = default;
virtual const std::string& alias() const = 0;
};

Expand Down
2 changes: 1 addition & 1 deletion Firestore/core/src/api/pipeline_result.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class PipelineResult {

PipelineResult() = default;

PipelineResult(model::Document document)
explicit PipelineResult(model::Document document)
: internal_key_{document->key()},
value_{document->shared_data()},
// TODO(pipeline): add create time support
Expand Down
1 change: 1 addition & 0 deletions Firestore/core/src/api/query_snapshot.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#include "Firestore/core/src/api/query_snapshot.h"

#include <utility>
#include <vector>

#include "Firestore/core/src/api/document_change.h"
#include "Firestore/core/src/api/document_snapshot.h"
Expand Down
1 change: 1 addition & 0 deletions Firestore/core/src/api/query_snapshot.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include <functional>
#include <memory>
#include <utility>
#include <vector>

#include "Firestore/core/src/api/api_fwd.h"
#include "Firestore/core/src/api/document_change.h"
Expand Down
2 changes: 1 addition & 1 deletion Firestore/core/src/api/realtime_pipeline_snapshot.h
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,4 @@ class RealtimePipelineSnapshot {
} // namespace firestore
} // namespace firebase

#endif // FIRESTORE_CORE_SRC_API_REAL_TIME_PIPELINE_SNAPSHOT_H_
#endif // FIRESTORE_CORE_SRC_API_REALTIME_PIPELINE_SNAPSHOT_H_
4 changes: 2 additions & 2 deletions Firestore/core/src/core/expressions_eval.cc
Original file line number Diff line number Diff line change
Expand Up @@ -584,8 +584,8 @@ template <typename T>
bool ProcessUtf8(const std::string& s,
T* result,
std::function<void(T*, uint32_t, absl::string_view)> func) {
int i = 0;
const int len = s.size();
size_t i = 0;
const size_t len = s.size();
const unsigned char* data = reinterpret_cast<const unsigned char*>(s.data());

while (i < len) {
Expand Down
2 changes: 1 addition & 1 deletion Firestore/core/src/core/view.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
#include <utility>
#include <valarray>

#include "Firestore/core/src/core/pipeline_run.h"
#include "Firestore/core/src/core/target.h"
#include "Firestore/core/src/model/document_set.h"
#include "Firestore/core/src/util/hard_assert.h" // For HARD_ASSERT and HARD_FAIL
#include "pipeline_run.h"

namespace firebase {
namespace firestore {
Expand Down
Loading