remove another lint config

Author: bkendall

eslint.config.mjs

@@ -24,9 +24,7 @@ export default [
       "jsdoc/require-param-type": "off",
       "jsdoc/require-returns-type": "off",
 
-      "@typescript-eslint/no-require-imports": "warn", // TODO(bkendall): remove allow to error.
-      "@typescript-eslint/no-unused-expressions": "warn", // TODO(bkendall): remove allow to error.
-      "@typescript-eslint/no-unused-vars": "warn", // TODO(bkendall): remove allow to error.
+      // "@typescript-eslint/no-require-imports": "warn", // TODO(bkendall): remove allow to error.
 
       "no-unused-vars": "off", // Turned off in favor of @typescript-eslint/no-unused-vars.
       "require-atomic-updates": "off", // This rule is so noisy and isn't useful: https://github.com/eslint/eslint/issues/11899

src/cli/index.ts

@@ -34,7 +34,7 @@ const ENV_FILENAME = ".env.json";
 let env: Record<string, string> | undefined = undefined;
 try {
   env = JSON.parse(fs.readFileSync(path.resolve(ENV_FILENAME), "utf8"));
-} catch (e) {
+} catch {
   // do nothing
 }
 

src/loaders/config-file.js

@@ -40,7 +40,7 @@ module.exports = function (filename) {
   // From custom config data passed in
   try {
     configObject = JSON.parse(filename);
-  } catch (e) {
+  } catch {
     if (_.isPlainObject(filename)) {
       configObject = filename;
       filename = CONFIG_FILE;
@@ -64,7 +64,7 @@ module.exports = function (filename) {
     try {
       config = JSON.parse(fs.readFileSync(path.resolve(filename)));
       config = config.hosting ?? config;
-    } catch (e) {
+    } catch {
       // do nothing
     }
   }

src/middleware/redirects.js

@@ -101,7 +101,7 @@ Redirect.prototype.test = function (url) {
         type: this.type,
         destination: encodeURI(addQuery(dest, qs)),
       };
-    } catch (e) {
+    } catch {
       return undefined;
     }
   } else if (

src/server.js

@@ -23,7 +23,6 @@ const connect = require("connect");
 const networkLogger = require("morgan");
 
 const superstatic = require("./superstatic");
-const { ServerOptions } = require("./options");
 
 /**
  * @param {ServerOptions} spec superstatic options.

src/superstatic.js

@@ -21,7 +21,6 @@
 
 const _ = require("lodash");
 const makerouter = require("router");
-const { HandleFunction } = require("connect");
 
 const fsProvider = require("./providers/fs");
 const Responder = require("./responder");
@@ -32,9 +31,6 @@ const promiseback = require("./utils/promiseback");
 const loadConfigFile = require("./loaders/config-file");
 const defaultCompressor = require("compression")();
 
-const { Configuration } = require("./config");
-const { MiddlewareOptions } = require("./options");
-
 const CWD = process.cwd();
 
 /**

src/utils/patterns.js

@@ -23,7 +23,7 @@ let RE2;
 const minimatch = require("minimatch");
 try {
   RE2 = require("re2");
-} catch (er) {
+} catch {
   RE2 = null;
 }
 

test/unit/providers/memory.spec.js

@@ -57,8 +57,8 @@ describe("memory provider", () => {
       a: await provider({}, "/a.html"),
       b: await provider({}, "/b.html"),
     }).then((result) => {
-      expect(result.a.etag).not.to.be.null;
-      expect(result.b.etag).not.to.be.null;
+      expect(result.a.etag).to.not.equal(null);
+      expect(result.b.etag).to.not.equal(null);
       expect(result.a.etag).not.to.eq(result.b.etag);
     });
   });

test/unit/responder.spec.js

@@ -128,7 +128,7 @@ describe("Responder", () => {
       return responder
         .handleRewrite({ rewrite: { message: "hi" } })
         .then((result) => {
-          expect(result).to.be.true;
+          expect(result).to.equal(true);
           expect(out).to.equal("hi");
         });
     });
@@ -153,7 +153,7 @@ describe("Responder", () => {
           next();
         })
         .then((result) => {
-          expect(result).to.be.false;
+          expect(result).to.equal(false);
         });
     });
   });
@@ -189,31 +189,31 @@ describe("Responder", () => {
     });
 
     it("should be false if there are no if-modified-since or if-none-match headers", () => {
-      expect(responder.isNotModified(result)).to.be.false;
+      expect(responder.isNotModified(result)).to.equal(false);
     });
 
     it("should be false if there is a non-matching etag", () => {
       responder.req.headers["if-none-match"] = "defabc";
-      expect(responder.isNotModified(result)).to.be.false;
+      expect(responder.isNotModified(result)).to.equal(false);
     });
 
     it("should be true if there is a matching etag", () => {
       responder.req.headers["if-none-match"] = "abcdef";
-      expect(responder.isNotModified(result)).to.be.true;
+      expect(responder.isNotModified(result)).to.equal(true);
     });
 
     it("should be true if there is an if-modified-since after the modified", () => {
       responder.req.headers["if-modified-since"] = new Date(
         result.modified + 30000,
       ).toUTCString();
-      expect(responder.isNotModified(result)).to.be.true;
+      expect(responder.isNotModified(result)).to.equal(true);
     });
 
     it("should be false if there is an if-modified-since before the modified", () => {
       responder.req.headers["if-modified-since"] = new Date(
         result.modified - 30000,
       ).toUTCString();
-      expect(responder.isNotModified(result)).to.be.false;
+      expect(responder.isNotModified(result)).to.equal(false);
     });
   });
 

test/unit/utils/pathutils.spec.ts

@@ -16,8 +16,8 @@ describe("pathutils", () => {
 
   describe("isDirectoryIndex", () => {
     it("should return true if the path ends with `index.html`", () => {
-      expect(pathutils.isDirectoryIndex("path/to/file.txt")).to.be.false;
-      expect(pathutils.isDirectoryIndex("path/to/index.html")).to.be.true;
+      expect(pathutils.isDirectoryIndex("path/to/file.txt")).to.equal(false);
+      expect(pathutils.isDirectoryIndex("path/to/index.html")).to.equal(true);
     });
   });