fix(release): run cargo check more reliably

Signed-off-by: Pablo Barbáchano <[email protected]>
(cherry picked from commit 4d12563)

Author: pb8o

tools/release-prepare.sh

@@ -4,6 +4,7 @@
 # SPDX-License-Identifier: Apache-2.0
 
 set -eu -o pipefail
+shopt -s lastpipe
 
 FC_TOOLS_DIR=$(dirname $(realpath $0))
 source "$FC_TOOLS_DIR/functions"
@@ -66,16 +67,15 @@ for file in "${files_to_change[@]}"; do
     sed -i "s/$prev_ver/$version/" "$file"
 done
 
-# Run `cargo check` to update firecracker and jailer versions in
+CHANGED=()
+# Run `cargo check` to update firecracker and jailer versions in all
 # `Cargo.lock`.
-say "Updating lockfile..."
-cargo check
-CHANGED=(Cargo.lock)
-
-cd tests/integration_tests/security/demo_seccomp
-cargo check
-cd -
-CHANGED+=(tests/integration_tests/security/demo_seccomp/Cargo.lock)
+# NOTE: This will break if it finds paths with spaces in them
+find . -path ./build -prune -o -name Cargo.lock -print |while read -r cargo_lock; do
+    say "Updating $cargo_lock ..."
+    (cd "$(dirname "$cargo_lock")"; cargo check)
+    CHANGED+=("$cargo_lock")
+done
 
 # Update credits.
 say "Updating credits..."

tools/release.sh

@@ -90,10 +90,10 @@ PROFILE_DIR=$(get-profile-dir "$PROFILE")
 CARGO_TARGET=$ARCH-unknown-linux-$LIBC
 CARGO_TARGET_DIR=build/cargo_target/$CARGO_TARGET/$PROFILE_DIR
 
-if [[ $VERSION =~ "-dirty$" ]]; then
+if [[ $VERSION = *-dirty ]]; then
     say_warn "Building dirty version.. dirty because:"
     git status -s --untracked-files=no
-    git diff
+    git --no-pager diff
 fi
 
 CARGO_REGISTRY_DIR="build/cargo_registry"