Maintenance 3 #5557
Open
Maintenance 3 #5557
+310
−257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
force-pushed
the
maintenance3
branch
3 times, most recently
from
ae25a1d to
ed4d917
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5557 +/- ##
==========================================
- Coverage 83.24% 83.22% -0.02%
==========================================
Files 277 277
Lines 29263 29282 +19
==========================================
+ Hits 24359 24370 +11
- Misses 4904 4912 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShadowCurse
force-pushed
the
maintenance3
branch
3 times, most recently
from
ba3cd70 to
694289e
Compare
ShadowCurse
added
Status: Awaiting review
JackThomson2
reviewed
Dec 4, 2025
ShadowCurse
force-pushed
the
maintenance3
branch
from
694289e to
a0966ff
Compare
Replace fmt.toml with new rustfmt.toml Signed-off-by: Egor Lazarchuk <[email protected]>
Fix new clippy warnings Signed-off-by: Egor Lazarchuk <[email protected]>
Instead of using `u32` values directly from generated `virtio_ids` create an enum backed by u8 with all types we actually use Signed-off-by: Egor Lazarchuk <[email protected]>
Add a trait method to VirtioDevice to get a unique device id. This can be used in default imps of some other methods to print current device id in case of an error/warning etc. Signed-off-by: Egor Lazarchuk <[email protected]>
Replace different `kick` implementations with a default implementation in the `VirtioDevice` trait. Change the `kick` logic to just re-trigger queue events instead of manually calling different internal queue processing functions. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
maintenance3
branch
from
a0966ff to
6587ebb
Compare
JackThomson2
reviewed
Dec 8, 2025
|
|
||
| /// Kick the device, as if it had received external events. | ||
| fn kick(&mut self) {} | ||
| fn kick(&mut self) { |
Contributor
There was a problem hiding this comment.
Do we want a test to ensure they are kicked?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
u32virtio device type with actualVirtioDeviceTypeenumidmethod toVirtioDevicetraitkickmethod inVirtioDevicetrait that re-triggers queue eventfds instead ofdoing manual queue reprocessing
Reason
Maintenance
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.