Skip to content

Conversation

@kalyazin
Copy link
Contributor

@kalyazin kalyazin commented Dec 3, 2025

Changes

Rename host metrics to use linux next.

Reason

Rename metrics published by memory hotplug and jailer tests so they are visible on the dashboard.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

Rename metrics published by memory hotplug and jailer tests so they are
visible on the dashboard.

Signed-off-by: Nikita Kalyazin <[email protected]>
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.35%. Comparing base (b2d3286) to head (d0986e2).
⚠️ Report is 1 commits behind head on feature/secret-hiding.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/secret-hiding    #5558   +/-   ##
======================================================
  Coverage                  82.35%   82.35%           
======================================================
  Files                        277      277           
  Lines                      29900    29900           
======================================================
  Hits                       24625    24625           
  Misses                      5275     5275           
Flag Coverage Δ
5.10-m5n.metal 82.44% <ø> (-0.05%) ⬇️
5.10-m6a.metal 81.74% <ø> (-0.01%) ⬇️
5.10-m6g.metal 79.31% <ø> (ø)
5.10-m6i.metal 82.43% <ø> (+<0.01%) ⬆️
5.10-m7a.metal-48xl 81.74% <ø> (+<0.01%) ⬆️
5.10-m7g.metal 79.31% <ø> (ø)
5.10-m7i.metal-24xl 82.40% <ø> (-0.01%) ⬇️
5.10-m7i.metal-48xl 82.40% <ø> (-0.02%) ⬇️
5.10-m8g.metal-24xl 79.31% <ø> (ø)
5.10-m8g.metal-48xl 79.31% <ø> (ø)
6.1-m5n.metal 82.46% <ø> (-0.01%) ⬇️
6.1-m6a.metal 81.77% <ø> (+<0.01%) ⬆️
6.1-m6g.metal 79.31% <ø> (ø)
6.1-m6i.metal 82.46% <ø> (-0.05%) ⬇️
6.1-m7a.metal-48xl 81.76% <ø> (ø)
6.1-m7g.metal 79.31% <ø> (ø)
6.1-m7i.metal-24xl 82.47% <ø> (-0.02%) ⬇️
6.1-m7i.metal-48xl 82.47% <ø> (ø)
6.1-m8g.metal-24xl 79.31% <ø> (ø)
6.1-m8g.metal-48xl 79.30% <ø> (-0.01%) ⬇️
6.17-m5n.metal 82.46% <ø> (-0.01%) ⬇️
6.17-m6a.metal 81.77% <ø> (-0.01%) ⬇️
6.17-m6g.metal 79.31% <ø> (ø)
6.17-m6i.metal 82.46% <ø> (ø)
6.17-m7a.metal-48xl 81.76% <ø> (ø)
6.17-m7g.metal 79.31% <ø> (ø)
6.17-m7i.metal-24xl 82.52% <ø> (+0.04%) ⬆️
6.17-m7i.metal-48xl 82.47% <ø> (-0.01%) ⬇️
6.17-m8g.metal-24xl 79.30% <ø> (-0.01%) ⬇️
6.17-m8g.metal-48xl 79.30% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kalyazin kalyazin self-assigned this Dec 3, 2025
@kalyazin kalyazin added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Dec 3, 2025
@kalyazin kalyazin merged commit 50c0543 into firecracker-microvm:feature/secret-hiding Dec 4, 2025
7 of 8 checks passed
@kalyazin kalyazin deleted the linux_next branch December 4, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants