Redo release workflow (#4609)

Redo release workflow

Summary of changes:
* Instead of making a release via the GUI triggering a PyPI publishing
  workflow the new approach is to trigger a workflow manually. That way
  we can do some safety checks before publishing.
* We now make releases from branches *off* `release`. This means that we
  can test the FIAT `release` branch against our own and also means that
  the version number in the `pyproject.toml` can have a `.dev0` suffix.
  This is useful because it means Python can distinguish between an
  install of the `release` branch and an actual release.

Author: connorjward

.github/workflows/core.yml

@@ -133,17 +133,6 @@ jobs:
             exit 1
           fi
 
-      # Raise an error if any 'TODO RELEASE' comments remain
-      - name: Check no 'TODO RELEASE' comments (release only)
-        if: inputs.target_branch == 'release'
-        working-directory: firedrake-repo
-        run: |
-          if [ -z "$( grep -r --exclude-dir='.*' 'TODO RELEASE' )" ]; then
-            exit 0
-          else
-            exit 1
-          fi
-
       - name: Install system dependencies (2)
         run: |
           apt-get -y install \

.github/workflows/release.yml

@@ -1,24 +1,72 @@
 name: Publish release
 
 on:
-  release:
-    types: [released]
+  workflow_call:
+    inputs:
+      branch:
+        description: The branch to release from
+        type: string
+        required: true
+      version:
+        description: The version number to release
+        type: string
+        required: true
 
 jobs:
-  deploy:
+  check:
+    name: Pre-release checks
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v5
+        with:
+          path: firedrake-repo
+          ref: ${{ inputs.branch }}
+
+      - name: Check no 'TODO RELEASE' comments remain
+        working-directory: firedrake-repo
+        run: |
+          if [ -z "$( grep -r --exclude-dir='.*' 'TODO RELEASE' )" ]; then
+            exit 0
+          else
+            exit 1
+          fi
+
+      - name: Check version number matches
+        working-directory: firedrake-repo
+        run: |
+          if [ -z "$( grep 'version = \"${{ inputs.version }}\"' pyproject.toml )" ]; then
+            exit 1
+          else
+            exit 0
+          fi
+
+  pypi:
     uses: ./.github/workflows/core.yml
+    needs: check
     with:
-      source_ref: release
+      source_ref: ${{ inputs.branch }}
       target_branch: release
       run_tests: false
       upload_pypi: true
     secrets: inherit
 
+  github_release:
+    name: Create GitHub release
+    needs: pypi
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+    steps:
+      - name: Create release
+        env:
+          GH_TOKEN: ${{ github.token }}
+        run: gh release create ${{ inputs.version }} --title ${{ inputs.version }} --generate-notes
+
   docker:
     name: Build Docker containers
     uses: ./.github/workflows/docker.yml
+    needs: pypi
     with:
-      tag: ${{ github.ref_name }}
-      branch: ${{ github.ref_name }}
-      build_dev: false
+      tag: ${{ inputs.version }}
+      branch: ${{ inputs.branch }}
     secrets: inherit

docs/source/install.rst

@@ -62,7 +62,7 @@ firedrake-configure
 To simplify the installation process, Firedrake provides a utility script called
 ``firedrake-configure``. This script can be downloaded by executing::
 
-  $ curl -O https://raw.githubusercontent.com/firedrakeproject/firedrake/refs/tags/2025.4.2/scripts/firedrake-configure
+  $ curl -O https://raw.githubusercontent.com/firedrakeproject/firedrake/release/scripts/firedrake-configure
 
 Unlike the now deprecated ``firedrake-install`` script, ``firedrake-configure``
 **does not install Firedrake for you**. It is simply a helper script that emits

pyproject.toml

@@ -1,7 +1,8 @@
 [project]
 name = "firedrake"
 # <year>.<month>.<patch>
-version = "2025.4.2"
+# TODO RELEASE: remove '.dev0'
+version = "2025.4.3.dev0"
 description = "An automated system for the portable solution of partial differential equations using the finite element method"
 readme = "README.rst"
 license = "LGPL-3.0-or-later"
@@ -20,7 +21,8 @@ dependencies = [
   "mpi4py>3; python_version >= '3.13'",
   "mpi4py; python_version < '3.13'",
   "fenics-ufl>=2025.1.0",
-  "firedrake-fiat>=2025.4.0",
+  # TODO RELEASE
+  "firedrake-fiat @ git+https://github.com/firedrakeproject/fiat.git@release",
   "h5py>3.12.1",
   "libsupermesh",
   "loopy>2024.1",

scripts/check-config

@@ -20,24 +20,12 @@ class InvalidConfigurationException(Exception):
 
 
 def main():
-    check_firedrake_version()
     check_min_python_version()
     check_petsc_version()
     check_slepc_version()
     check_petsc_version_spec()
 
 
-def check_firedrake_version():
-    firedrake_version = check_file_contains_pattern(
-        REPO_ROOT / "pyproject.toml",
-        "version = \"(.*)\""
-    )
-    check_file_contains_pattern(
-        REPO_ROOT/"docs/source/install.rst",
-        f"https://raw.githubusercontent.com/firedrakeproject/firedrake/refs/tags/{firedrake_version}/scripts/firedrake-configure"
-    )
-
-
 def check_min_python_version() -> None:
     min_python_version = check_file_contains_pattern(
         REPO_ROOT / "pyproject.toml",