Skip to content
This repository was archived by the owner on Sep 21, 2021. It is now read-only.

Commit 7b0c558

Browse files
authored
update RootClient getFront endpoint (#1085)
1 parent 975f2b3 commit 7b0c558

File tree

4 files changed

+39
-11
lines changed

4 files changed

+39
-11
lines changed

packages/devtools-connection/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "devtools-connection",
3-
"version": "0.0.9",
3+
"version": "0.0.12",
44
"description": "DevTools HTML Connection Logic",
55
"main": "index.js",
66
"scripts": {

packages/devtools-connection/src/debugger/client.js

+22-4
Original file line numberDiff line numberDiff line change
@@ -424,8 +424,8 @@ DebuggerClient.prototype = {
424424
* This function exists only to preserve DebuggerClient's interface;
425425
* new code should say 'client.mainRoot.listTabs()'.
426426
*/
427-
listTabs: function() {
428-
return this.mainRoot.listTabs();
427+
listTabs: function(aOnResponse) {
428+
return this.mainRoot.listTabs(aOnResponse);
429429
},
430430

431431
/*
@@ -1623,6 +1623,20 @@ AddonClient.prototype = {
16231623
),
16241624
};
16251625

1626+
1627+
async function getDeviceFront() {
1628+
return {
1629+
getDescription: function () {
1630+
return {
1631+
// Return anything that will not match Fennec v60
1632+
apptype: "apptype",
1633+
version: "version"
1634+
};
1635+
}
1636+
};
1637+
}
1638+
1639+
16261640
/**
16271641
* A RootClient object represents a root actor on the server. Each
16281642
* DebuggerClient keeps a RootClient instance representing the root actor
@@ -1654,6 +1668,10 @@ exports.RootClient = RootClient;
16541668
RootClient.prototype = {
16551669
constructor: RootClient,
16561670

1671+
getFront: function(name) {
1672+
return getDeviceFront();
1673+
},
1674+
16571675
/**
16581676
* List the open tabs.
16591677
*
@@ -2779,8 +2797,8 @@ ObjectClient.prototype = {
27792797
},
27802798
{
27812799
before: function(packet) {
2782-
if (!["Map", "WeakMap", "Set", "WeakSet", "Storage"].includes(this._grip.class)) {
2783-
throw new Error("enumEntries is only valid for Map/Set/Storage-like grips.");
2800+
if (!["Map", "WeakMap", "Set", "WeakSet"].includes(this._grip.class)) {
2801+
throw new Error("enumEntries is only valid for Map/Set-like grips.");
27842802
}
27852803
return packet;
27862804
},

packages/devtools-launchpad/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "devtools-launchpad",
3-
"version": "0.0.132",
3+
"version": "0.0.134",
44
"license": "MPL-2.0",
55
"description": "The Launchpad makes it easy to build a developer tool for Firefox, Chrome, and Node.",
66
"repository": {
@@ -50,7 +50,7 @@
5050
"css-loader": "^0.26.1",
5151
"debug": "^3.1.0",
5252
"devtools-config": "^0.0.16",
53-
"devtools-connection": "^0.0.9",
53+
"devtools-connection": "0.0.12",
5454
"devtools-contextmenu": "^0.0.9",
5555
"devtools-environment": "^0.0.5",
5656
"devtools-license-check": "^0.7.0",
@@ -79,9 +79,9 @@
7979
"properties-parser": "^0.3.1",
8080
"ps-node": "^0.1.4",
8181
"raw-loader": "^0.5.1",
82-
"react-dom-factories": "^1.0.2",
8382
"react": "^16.4.1",
8483
"react-dom": "^16.4.1",
84+
"react-dom-factories": "^1.0.2",
8585
"react-redux": "^5.0.6",
8686
"redux": "^3.7.2",
8787
"selenium-webdriver": "=3.3.0",

packages/devtools-launchpad/yarn.lock

+13-3
Original file line numberDiff line numberDiff line change
@@ -1840,9 +1840,9 @@ devtools-config@^0.0.16:
18401840
version "0.0.16"
18411841
resolved "https://registry.yarnpkg.com/devtools-config/-/devtools-config-0.0.16.tgz#e7251788422f42a16aa1372b6adbebfcb7a74994"
18421842

1843-
devtools-connection@^0.0.9:
1844-
version "0.0.9"
1845-
resolved "https://registry.yarnpkg.com/devtools-connection/-/devtools-connection-0.0.9.tgz#31121090c8594da7bcc5ee763a34002de932f317"
1843+
1844+
version "0.0.12"
1845+
resolved "https://registry.yarnpkg.com/devtools-connection/-/devtools-connection-0.0.12.tgz#a1bb6add55e4b317dd5122c25d3bb47bc896918c"
18461846

18471847
devtools-contextmenu@^0.0.9:
18481848
version "0.0.9"
@@ -4047,12 +4047,22 @@ mime-db@~1.33.0:
40474047
version "1.33.0"
40484048
resolved "https://registry.yarnpkg.com/mime-db/-/mime-db-1.33.0.tgz#a3492050a5cb9b63450541e39d9788d2272783db"
40494049

4050+
mime-db@~1.36.0:
4051+
version "1.36.0"
4052+
resolved "https://registry.yarnpkg.com/mime-db/-/mime-db-1.36.0.tgz#5020478db3c7fe93aad7bbcc4dcf869c43363397"
4053+
40504054
mime-types@^2.1.12, mime-types@~2.1.17, mime-types@~2.1.18:
40514055
version "2.1.18"
40524056
resolved "https://registry.yarnpkg.com/mime-types/-/mime-types-2.1.18.tgz#6f323f60a83d11146f831ff11fd66e2fe5503bb8"
40534057
dependencies:
40544058
mime-db "~1.33.0"
40554059

4060+
mime-types@^2.1.18:
4061+
version "2.1.20"
4062+
resolved "https://registry.yarnpkg.com/mime-types/-/mime-types-2.1.20.tgz#930cb719d571e903738520f8470911548ca2cc19"
4063+
dependencies:
4064+
mime-db "~1.36.0"
4065+
40564066
40574067
version "1.3.6"
40584068
resolved "https://registry.yarnpkg.com/mime/-/mime-1.3.6.tgz#591d84d3653a6b0b4a3b9df8de5aa8108e72e5e0"

0 commit comments

Comments
 (0)