fix #5153: When logging out the homepage is fetched twice. #5160
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logout request handler may respond with a simple 204-NoContent. The originating view already contains redirection. As reported on the forum, some servers don't cope well.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5160 +/- ##
============================================
- Coverage 35.53% 35.07% -0.46%
- Complexity 11143 11204 +61
============================================
Files 1157 1161 +4
Lines 47737 48488 +751
============================================
+ Hits 16961 17009 +48
- Misses 30776 31479 +703 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ponse or redirection Check whether header 'X-Requested-With' is not empty, similar as done in HandleExceptions.php so actual value of the header may change and not affect this behaviour.
BertKoor
force-pushed
the
issue5153_logoutTriggersFetchHomeTwice
branch
from
76d4626 to
f9ced6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logout request handler may respond with a simple 204-NoContent. The originating view already contains redirection. As reported on the forum, some servers don't cope well.
Affected user reported back this patch does the trick: logout goes smoothly.