Skip to content

Commit 2819c51

Browse files
committed
test: Use rpc_deprecated only for testing deprecation
1 parent 79bbb38 commit 2819c51

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

test/functional/rpc_deprecated.py

+11-11
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,29 @@
11
#!/usr/bin/env python3
2-
# Copyright (c) 2017-2021 The Bitcoin Core developers
2+
# Copyright (c) 2017-2025 The Bitcoin Core developers
33
# Distributed under the MIT software license, see the accompanying
44
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
55
"""Test deprecation of RPC calls."""
66
from test_framework.test_framework import BitcoinTestFramework
77

88
class DeprecatedRpcTest(BitcoinTestFramework):
99
def set_test_params(self):
10-
self.num_nodes = 2
10+
self.num_nodes = 1
1111
self.setup_clean_chain = True
12-
self.extra_args = [[], ['-deprecatedrpc=bumpfee']]
12+
self.extra_args = [[]]
1313

1414
def run_test(self):
15-
# This test should be used to verify correct behaviour of deprecated
16-
# RPC methods with and without the -deprecatedrpc flags. For example:
15+
# This test should be used to verify the errors of the currently
16+
# deprecated RPC methods (without the -deprecatedrpc flag) until
17+
# such RPCs are fully removed. For example:
1718
#
18-
# In set_test_params:
19-
# self.extra_args = [[], ["-deprecatedrpc=generate"]]
20-
#
21-
# In run_test:
2219
# self.log.info("Test generate RPC")
2320
# assert_raises_rpc_error(-32, 'The wallet generate rpc method is deprecated', self.nodes[0].rpc.generate, 1)
24-
# self.generate(self.nodes[1], 1)
21+
#
22+
# Please ensure that for all the RPC methods tested here, there is
23+
# at least one other functional test that still tests the RPCs
24+
# functionality using the respective -deprecatedrpc flag.
2525

26-
self.log.info("No tested deprecated RPC methods")
26+
self.log.info("Currently no tests for deprecated RPC methods")
2727

2828
if __name__ == '__main__':
2929
DeprecatedRpcTest(__file__).main()

0 commit comments

Comments
 (0)