DVO-1021: Switch to goccy/go-json (#730)

ilyaluk · web-flow · commit f62940ba4fc2 · 2025-05-13T19:13:49.000+02:00
* DVO-1021: Switch to goccy/go-json

This should improve latencies of some requests

* DVO-1021: Fix failing test

goccy/json doesn't support marshalling **SomeType values

* fix linter
diff --git a/beaconclient/prod_beacon_instance.go b/beaconclient/prod_beacon_instance.go
@@ -1,7 +1,6 @@
 package beaconclient
 
 import (
-	"encoding/json"
 	"fmt"
 	"net/http"
 	"os"
@@ -10,6 +9,7 @@ import (
 
 	"github.com/attestantio/go-eth2-client/spec/capella"
 	"github.com/flashbots/mev-boost-relay/common"
+	"github.com/goccy/go-json"
 	"github.com/r3labs/sse/v2"
 	"github.com/sirupsen/logrus"
 )
diff --git a/beaconclient/util.go b/beaconclient/util.go
@@ -2,12 +2,13 @@ package beaconclient
 
 import (
 	"bytes"
-	"encoding/json"
 	"errors"
 	"fmt"
 	"io"
 	"net/http"
 	"strings"
+
+	"github.com/goccy/go-json"
 )
 
 var (
diff --git a/cmd/tool/archive-execution-payloads.go b/cmd/tool/archive-execution-payloads.go
@@ -2,13 +2,13 @@ package tool
 
 import (
 	"encoding/csv"
-	"encoding/json"
 	"net/url"
 	"os"
 	"strings"
 
 	"github.com/flashbots/mev-boost-relay/database"
 	"github.com/flashbots/mev-boost-relay/database/vars"
+	"github.com/goccy/go-json"
 	"github.com/spf13/cobra"
 )
 
diff --git a/cmd/tool/export-data-api-payloads-bids.go b/cmd/tool/export-data-api-payloads-bids.go
@@ -2,7 +2,6 @@ package tool
 
 import (
 	"encoding/csv"
-	"encoding/json"
 	"fmt"
 	"net/url"
 	"os"
@@ -11,6 +10,7 @@ import (
 
 	"github.com/flashbots/mev-boost-relay/common"
 	"github.com/flashbots/mev-boost-relay/database"
+	"github.com/goccy/go-json"
 	"github.com/spf13/cobra"
 )
 
diff --git a/cmd/tool/export-data-api-payloads-delivered.go b/cmd/tool/export-data-api-payloads-delivered.go
@@ -2,14 +2,14 @@ package tool
 
 import (
 	"encoding/csv"
-	"encoding/json"
 	"net/url"
 	"os"
 	"strings"
 
 	"github.com/flashbots/mev-boost-relay/common"
 	"github.com/flashbots/mev-boost-relay/database"
 	"github.com/flashbots/mev-boost-relay/database/vars"
+	"github.com/goccy/go-json"
 	"github.com/spf13/cobra"
 )
 
diff --git a/common/ssz_test.go b/common/ssz_test.go
@@ -2,7 +2,6 @@ package common
 
 import (
 	"bytes"
-	"encoding/json"
 	"os"
 	"testing"
 
@@ -11,6 +10,7 @@ import (
 	builderSpec "github.com/attestantio/go-builder-client/spec"
 	"github.com/attestantio/go-eth2-client/spec"
 	"github.com/ethereum/go-ethereum/common/hexutil"
+	"github.com/goccy/go-json"
 	"github.com/stretchr/testify/require"
 )
 
diff --git a/common/test_utils.go b/common/test_utils.go
@@ -4,7 +4,6 @@ import (
 	"bytes"
 	"compress/gzip"
 	"encoding/base64"
-	"encoding/json"
 	"io"
 	"os"
 	"testing"
@@ -23,6 +22,7 @@ import (
 	"github.com/flashbots/go-boost-utils/bls"
 	"github.com/flashbots/go-boost-utils/ssz"
 	"github.com/flashbots/go-boost-utils/utils"
+	"github.com/goccy/go-json"
 	"github.com/holiman/uint256"
 	"github.com/sirupsen/logrus"
 	"github.com/stretchr/testify/require"
diff --git a/common/types.go b/common/types.go
@@ -1,7 +1,6 @@
 package common
 
 import (
-	"encoding/json"
 	"errors"
 	"fmt"
 	"os"
@@ -19,6 +18,7 @@ import (
 	ssz "github.com/ferranbt/fastssz"
 	boostSsz "github.com/flashbots/go-boost-utils/ssz"
 	"github.com/flashbots/go-boost-utils/utils"
+	"github.com/goccy/go-json"
 )
 
 var (
diff --git a/common/types_spec.go b/common/types_spec.go
@@ -2,7 +2,6 @@ package common
 
 import (
 	"bytes"
-	"encoding/json"
 	"fmt"
 
 	builderApi "github.com/attestantio/go-builder-client/api"
@@ -24,6 +23,7 @@ import (
 	"github.com/flashbots/go-boost-utils/bls"
 	"github.com/flashbots/go-boost-utils/ssz"
 	"github.com/flashbots/go-boost-utils/utils"
+	"github.com/goccy/go-json"
 	"github.com/holiman/uint256"
 	"github.com/pkg/errors"
 )
diff --git a/common/types_spec_test.go b/common/types_spec_test.go
@@ -2,10 +2,10 @@ package common
 
 import (
 	"bytes"
-	"encoding/json"
 	"testing"
 
 	"github.com/attestantio/go-eth2-client/spec"
+	"github.com/goccy/go-json"
 	"github.com/stretchr/testify/require"
 )
 
diff --git a/common/utils.go b/common/utils.go
@@ -4,7 +4,6 @@ import (
 	"bytes"
 	"context"
 	"encoding/hex"
-	"encoding/json"
 	"errors"
 	"fmt"
 	"io"
@@ -22,6 +21,7 @@ import (
 	"github.com/ethereum/go-ethereum/common/hexutil"
 	"github.com/flashbots/go-boost-utils/ssz"
 	"github.com/flashbots/go-boost-utils/types"
+	"github.com/goccy/go-json"
 	"github.com/holiman/uint256"
 )
 
diff --git a/database/database.go b/database/database.go
@@ -4,7 +4,6 @@ package database
 import (
 	"context"
 	"database/sql"
-	"encoding/json"
 	"fmt"
 	"os"
 	"strings"
@@ -14,6 +13,7 @@ import (
 	"github.com/flashbots/mev-boost-relay/common"
 	"github.com/flashbots/mev-boost-relay/database/migrations"
 	"github.com/flashbots/mev-boost-relay/database/vars"
+	"github.com/goccy/go-json"
 	"github.com/holiman/uint256"
 	"github.com/jmoiron/sqlx"
 	_ "github.com/lib/pq"
@@ -256,7 +256,7 @@ func (s *DatabaseService) SaveBuilderBlockSubmission(payload *common.VersionedSu
 }
 
 func (s *DatabaseService) GetBlockSubmissionEntry(slot uint64, proposerPubkey, blockHash string) (entry *BuilderBlockSubmissionEntry, err error) {
-	query := `SELECT id, inserted_at, received_at, eligible_at, execution_payload_id, sim_success, sim_error, signature, slot, parent_hash, block_hash, builder_pubkey, proposer_pubkey, proposer_fee_recipient, gas_used, gas_limit, num_tx, value, epoch, block_number, decode_duration, prechecks_duration, simulation_duration, redis_update_duration, total_duration, optimistic_submission 
+	query := `SELECT id, inserted_at, received_at, eligible_at, execution_payload_id, sim_success, sim_error, signature, slot, parent_hash, block_hash, builder_pubkey, proposer_pubkey, proposer_fee_recipient, gas_used, gas_limit, num_tx, value, epoch, block_number, decode_duration, prechecks_duration, simulation_duration, redis_update_duration, total_duration, optimistic_submission
 	FROM ` + vars.TableBuilderBlockSubmission + `
 	WHERE slot=$1 AND proposer_pubkey=$2 AND block_hash=$3
 	ORDER BY builder_pubkey ASC
diff --git a/database/typesconv.go b/database/typesconv.go
@@ -1,14 +1,14 @@
 package database
 
 import (
-	"encoding/json"
 	"errors"
 
 	builderApi "github.com/attestantio/go-builder-client/api"
 	builderApiDeneb "github.com/attestantio/go-builder-client/api/deneb"
 	"github.com/attestantio/go-eth2-client/spec"
 	"github.com/attestantio/go-eth2-client/spec/capella"
 	"github.com/flashbots/mev-boost-relay/common"
+	"github.com/goccy/go-json"
 )
 
 var ErrUnsupportedExecutionPayload = errors.New("unsupported execution payload version")
diff --git a/datastore/memcached.go b/datastore/memcached.go
@@ -1,13 +1,13 @@
 package datastore
 
 import (
-	"encoding/json"
 	"fmt"
 	"time"
 
 	builderApi "github.com/attestantio/go-builder-client/api"
 	"github.com/bradfitz/gomemcache/memcache"
 	"github.com/flashbots/go-utils/cli"
+	"github.com/goccy/go-json"
 )
 
 var (
diff --git a/datastore/redis.go b/datastore/redis.go
@@ -2,7 +2,6 @@ package datastore
 
 import (
 	"context"
-	"encoding/json"
 	"errors"
 	"fmt"
 	"math/big"
@@ -18,6 +17,7 @@ import (
 	"github.com/attestantio/go-eth2-client/spec/capella"
 	"github.com/flashbots/go-utils/cli"
 	"github.com/flashbots/mev-boost-relay/common"
+	"github.com/goccy/go-json"
 	"github.com/redis/go-redis/v9"
 )
 
diff --git a/go.mod b/go.mod
@@ -14,6 +14,7 @@ require (
 	github.com/ethereum/go-ethereum v1.15.10
 	github.com/flashbots/go-boost-utils v1.9.0
 	github.com/flashbots/go-utils v0.11.0
+	github.com/goccy/go-json v0.10.4
 	github.com/gorilla/mux v1.8.1
 	github.com/holiman/uint256 v1.3.2
 	github.com/jmoiron/sqlx v1.4.0
diff --git a/go.sum b/go.sum
@@ -106,6 +106,8 @@ github.com/go-ole/go-ole v1.3.0 h1:Dt6ye7+vXGIKZ7Xtk4s6/xVdGDQynvom7xCFEdWr6uE=
 github.com/go-ole/go-ole v1.3.0/go.mod h1:5LS6F96DhAwUc7C+1HLexzMXY1xGRSryjyPPKW6zv78=
 github.com/go-sql-driver/mysql v1.8.1 h1:LedoTUt/eveggdHS9qUFC1EFSa8bU2+1pZjSRpvNJ1Y=
 github.com/go-sql-driver/mysql v1.8.1/go.mod h1:wEBSXgmK//2ZFJyE+qWnIsVGmvmEKlqwuVSjsCm7DZg=
+github.com/goccy/go-json v0.10.4 h1:JSwxQzIqKfmFX1swYPpUThQZp/Ka4wzJdK0LWVytLPM=
+github.com/goccy/go-json v0.10.4/go.mod h1:oq7eo15ShAhp70Anwd5lgX2pLfOS3QCiwU/PULtXL6M=
 github.com/goccy/go-yaml v1.17.1 h1:LI34wktB2xEE3ONG/2Ar54+/HJVBriAGJ55PHls4YuY=
 github.com/goccy/go-yaml v1.17.1/go.mod h1:XBurs7gK8ATbW4ZPGKgcbrY1Br56PdM69F7LkFRi1kA=
 github.com/gofrs/flock v0.12.1 h1:MTLVXXHf8ekldpJk3AKicLij9MdwOWkZ+a/jHHZby9E=
diff --git a/scripts/website-staticgen/main.go b/scripts/website-staticgen/main.go
@@ -2,12 +2,12 @@ package main
 
 import (
 	"bytes"
-	"encoding/json"
 	"fmt"
 	"io"
 	"os"
 
 	"github.com/flashbots/mev-boost-relay/services/website"
+	"github.com/goccy/go-json"
 )
 
 func main() {
diff --git a/services/api/blocksim_ratelimiter.go b/services/api/blocksim_ratelimiter.go
@@ -3,7 +3,6 @@ package api
 import (
 	"bytes"
 	"context"
-	"encoding/json"
 	"errors"
 	"fmt"
 	"io"
@@ -16,6 +15,7 @@ import (
 	"github.com/flashbots/go-utils/cli"
 	"github.com/flashbots/go-utils/jsonrpc"
 	"github.com/flashbots/mev-boost-relay/common"
+	"github.com/goccy/go-json"
 )
 
 var (
diff --git a/services/api/optimistic_test.go b/services/api/optimistic_test.go
@@ -1,7 +1,6 @@
 package api
 
 import (
-	"encoding/json"
 	"errors"
 	"math/big"
 	"net/http"
@@ -22,6 +21,7 @@ import (
 	"github.com/flashbots/mev-boost-relay/common"
 	"github.com/flashbots/mev-boost-relay/database"
 	"github.com/flashbots/mev-boost-relay/datastore"
+	"github.com/goccy/go-json"
 	"github.com/holiman/uint256"
 	"github.com/stretchr/testify/require"
 )
@@ -137,7 +137,7 @@ func runOptimisticBlockSubmission(t *testing.T, opts blockRequestOpts, simErr er
 	}
 
 	req := common.TestBuilderSubmitBlockRequest(opts.secretkey, getTestBidTrace(opts.pubkey, opts.blockValue, opts.slot), opts.version)
-	rr := backend.request(http.MethodPost, pathSubmitNewBlock, &req)
+	rr := backend.request(http.MethodPost, pathSubmitNewBlock, req)
 
 	// Let updates happen async.
 	time.Sleep(100 * time.Millisecond)
@@ -372,7 +372,7 @@ func TestBuilderApiSubmitNewBlockOptimistic(t *testing.T) {
 		wantStatus      common.BuilderStatus
 		simulationError error
 		expectDemotion  bool
-		httpCode        uint64
+		httpCode        int
 		blockValue      uint64
 		slot            uint64
 		version         spec.DataVersion
@@ -488,7 +488,7 @@ func TestBuilderApiSubmitNewBlockOptimistic(t *testing.T) {
 			}, tc.simulationError, backend)
 
 			// Check http code.
-			require.EqualValues(t, rr.Code, tc.httpCode)
+			require.EqualValues(t, tc.httpCode, rr.Code)
 
 			// Check status in db.
 			builder, err := backend.relay.db.GetBlockBuilderByPubkey(pkStr)
@@ -499,7 +499,7 @@ func TestBuilderApiSubmitNewBlockOptimistic(t *testing.T) {
 			// Check demotion status is set to expected and refund is false.
 			mockDB, ok := backend.relay.db.(*database.MockDB)
 			require.True(t, ok)
-			require.Equal(t, mockDB.Demotions[pkStr], tc.expectDemotion)
+			require.Equal(t, tc.expectDemotion, mockDB.Demotions[pkStr])
 			require.False(t, mockDB.Refunds[pkStr])
 		})
 	}
diff --git a/services/api/service.go b/services/api/service.go
@@ -5,7 +5,6 @@ import (
 	"compress/gzip"
 	"context"
 	"database/sql"
-	"encoding/json"
 	"fmt"
 	"io"
 	"math/big"
@@ -38,6 +37,7 @@ import (
 	"github.com/flashbots/mev-boost-relay/database"
 	"github.com/flashbots/mev-boost-relay/datastore"
 	"github.com/flashbots/mev-boost-relay/metrics"
+	"github.com/goccy/go-json"
 	"github.com/gorilla/mux"
 	"github.com/holiman/uint256"
 	"github.com/pkg/errors"
@@ -1492,7 +1492,7 @@ func (api *RelayAPI) handleGetPayload(w http.ResponseWriter, req *http.Request)
 	ok, err := api.checkProposerSignature(payload, pk[:])
 	if !ok || err != nil {
 		if api.ffLogInvalidSignaturePayload {
-			txt, _ := json.Marshal(payload) //nolint:errchkjson
+			txt, _ := json.Marshal(payload)
 			log.Info("payload_invalid_sig: ", string(txt), "pubkey:", proposerPubkey)
 		}
 		log.WithError(err).Warn("could not verify payload signature")
diff --git a/services/api/service_test.go b/services/api/service_test.go
@@ -3,7 +3,6 @@ package api
 import (
 	"bytes"
 	"compress/gzip"
-	"encoding/json"
 	"fmt"
 	"math/big"
 	"net/http"
@@ -27,6 +26,7 @@ import (
 	"github.com/flashbots/mev-boost-relay/common"
 	"github.com/flashbots/mev-boost-relay/database"
 	"github.com/flashbots/mev-boost-relay/datastore"
+	"github.com/goccy/go-json"
 	"github.com/holiman/uint256"
 	"github.com/sirupsen/logrus"
 	"github.com/stretchr/testify/require"

Original file line number	Diff line number	Diff line change
`@@ -2,10 +2,10 @@ package common`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"bytes"`
`5`		`- "encoding/json"`
`6`	`5`	`"testing"`
`7`	`6`
`8`	`7`	`"github.com/attestantio/go-eth2-client/spec"`
	`8`	`+ "github.com/goccy/go-json"`
`9`	`9`	`"github.com/stretchr/testify/require"`
`10`	`10`	`)`
`11`	`11`